fix: updating atxCredentialProvider accessible in server #718
+14
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huawenm
approved these changes
Nov 22, 2025
ashishrp-aws
approved these changes
Nov 24, 2025
chungjac
approved these changes
Nov 24, 2025
Contributor
chungjac
left a comment
chungjac
left a comment
There was a problem hiding this comment.
I don't have much context here, but approving to unblock releasing of new runtimes version
rli
approved these changes
Nov 24, 2025
chungjac
pushed a commit
that referenced
this pull request
Nov 24, 2025
🤖 I have created a release *beep* *boop* --- <details><summary>language-server-runtimes: 0.3.8</summary> ## [0.3.8](language-server-runtimes/v0.3.7...language-server-runtimes/v0.3.8) (2025-11-24) ### Bug Fixes * updating atxCredentialProvider accessible in server ([#718](#718)) ([a0b50d4](a0b50d4)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
GetAtxCredentialProvider was not getting called
Solution
Added optional parameter for atxCredential provider
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.