support setting resource limits on encryption provider pode #380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
It seems there is a golang version dependency needs to be fixed to make the CI pass. |
Contributor
could we fix that ? otherwise PR LGTM! |
prateekgogia
reviewed
Mar 1, 2023
| go install github.com/onsi/ginkgo/[email protected] | ||
| go install sigs.k8s.io/controller-runtime/tools/[email protected] | ||
| go install sigs.k8s.io/controller-tools/cmd/controller-gen@v0.8.0 | ||
| go install sigs.k8s.io/controller-tools/cmd/controller-gen@v0.11.3 |
Contributor
There was a problem hiding this comment.
Do we need to update this?
Co-authored-by: Prateek Gogia <[email protected]>
Contributor
|
Do we still need this PR at this point ? Or do we want to close this out for now ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.