Skip to content

Conversation

@brigand
Copy link
Collaborator

@brigand brigand commented Aug 9, 2014

So... this component is weird. We probably at least want to improve the styles.

Here's an example of it in jsbin.

@karlmikko
Copy link
Collaborator

I think this should be 3 components

1 controller with validation (needs more char - limit char)
1 textarea with onChange given to controller
1 label

controller onChange then to pass the val to the textarea and pass the count / max / has-error to the label

that way you can test the textarea and the label separately

@brigand
Copy link
Collaborator Author

brigand commented Aug 9, 2014

Having a bit of difficulty seeing this, could you give a usage example for those? e.g. <Label message="not enough characters" status="bad" />?

@karlmikko
Copy link
Collaborator

It is more moving renderRemaining to a new component and passing it the bits it needs

@karlmikko
Copy link
Collaborator

working on jsbin

@brigand
Copy link
Collaborator Author

brigand commented Aug 9, 2014

Ah okay... yeah that's a somewhat lazy pattern I've gotten into... I'll try not to do that.

@karlmikko
Copy link
Collaborator

http://jsbin.com/xewayoti/1/edit updated

@karlmikko
Copy link
Collaborator

updated jsbin

hojberg and others added 4 commits August 8, 2014 22:16
* Add `<MainHeader/>` with logo and navigation
* Add `<MainNav/>` with nav items. Also tracks current page
* Update folder structure for /client and /test
* Add `npm run build`
@brigand
Copy link
Collaborator Author

brigand commented Aug 9, 2014

Awesome! I committed your changes (there was a syntax error in the jsbin for some reason, so just fixed that).

@karlmikko
Copy link
Collaborator

Thinking on this more - do we need this to have a min? as it would reduce complexity of the component and still be size limited.

I was just wondering if it would be easier to comprehend as a reader new to the concepts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants