Open
Conversation
- Current query resamples the data using the 'mean' function - which is unoptimal Changed to first/min/max/last - It seems that fromdate parameter is ignored - resulting in excessive data fetch From date and to date added in. - Openinterest field seems to be ignored even if present in the data Open interest added in. - Time precision is excessive (nano-seconds vs seconds ) Left unchanged.
vladisld
reviewed
Aug 31, 2021
vladisld
left a comment
vladisld
left a comment
There was a problem hiding this comment.
does this change contain only the cosmetic changes or also the functional ones?
Generally it is preferable to split such commits - keep the functional changes in one commit and all the cosmetics into other. You'll get two benefits this way:
- cosmetics will not clutter the functional changes - making the review easier and more focused
- make it possible to revert it without reverting all the cosmetics and vice versa
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed to first/min/max/last
From date and to date added in.
Open interest added in.
Left unchanged.