Skip to content

Conversation

@badasswp
Copy link
Owner

This PR resolves this issue.

Description / Background Context

At the moment, when a user selects a text and opens up the search and replace modal, we don't see the number of items that are found immediately. This PR resolves this issue so that when users select a text in the block editor and open up the modal, they are immediately shown the number of items found, if any.

Image

Testing Instructions

  • Pull PR to local.
  • Build correctly using yarn build.
  • Highlight any text in the block editor.
  • Click on Search & Replace icon.
  • Observe that number of items found are shown immediately in the modal.
  • Close Modal.
  • Deselect highlighted text and open modal again.
  • Observe that number of items are not shown since no text is highlighted.
  • Observe that there are no regressions introduced as a result of this change.

@badasswp badasswp self-assigned this Oct 27, 2025
@badasswp badasswp added enhancement New feature or request chore An assigned task to be done labels Oct 27, 2025
@badasswp badasswp linked an issue Oct 27, 2025 that may be closed by this pull request
@badasswp badasswp merged commit 0c90a33 into release-1.7.0 Oct 27, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore An assigned task to be done enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feat: On Modal open, show items found for Highlighted text

2 participants