Skip to content

Fix definition and use of the PYTHONVERSION in steps #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
hugtalbot wants to merge 58 commits into
base: master
Choose a base branch
from
Open

Fix definition and use of the PYTHONVERSION in steps #32

hugtalbot wants to merge 58 commits into from

Conversation

@hugtalbot
Copy link
Collaborator

@hugtalbot hugtalbot commented Apr 29, 2025

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

bakpaul and others added 30 commits April 22, 2025 15:21
@bakpaul
Test action
3a1c167
@bakpaul
Fix action
978ef1a
@bakpaul
Test pre job hook
0c2f7f0
@bakpaul
Add setup_build step
1a874b1
@bakpaul
Fix action
033bd3c
@bakpaul
FIX when folders already exist + TODOS
c5fda97
@hugtalbot @bakpaul
Add filter action and scripts
14d7d2a
@hugtalbot @bakpaul
replace sofa-framework by bakpaul
9725eb2
@hugtalbot @bakpaul
fix indentation
c0c5975
@hugtalbot @bakpaul
add checkout code action
1fade70
@bakpaul
Add backbone
a521a1a
@bakpaul
Cloning SOFA working
6331407
@bakpaul
Forgot to save
896e09c
@hugtalbot @bakpaul
add chmod to run script
7c2d16a
@hugtalbot @bakpaul
Add call-workflow, refactor env variables, update python script
c2db438
@hugtalbot @bakpaul
remove useless comment
a40fb35
@hugtalbot @bakpaul
Apply suggestions from code review
9a68617
@hugtalbot @bakpaul
Apply suggestions from code review
08cf72e
@hugtalbot @bakpaul
Update filter-build.yml
a901365
@bakpaul
Finalize clone sofa and ci (#7)
3ff4ae3 
* Push space to creatye PR

* Finished clone sofa and ci stage

* Rename action

* fix some typos in filter script
@bakpaul
Add build step (#8)
22aa451 
* Commit to open a PR

* revert env modification

* Move steps around + add os configuration

* Configure step should be working

* Move comment around

* Step build
@hugtalbot @bakpaul
Use step outputs to send variables in call workflow (#9)
8831138 
* Use step outputs to send variables in call workflow

* add BUILDER_OS environment variable

* add check for all tests in PR body

* remove useless secret

* udpate PR python script

* add missing runs-on: ubuntu-latest

* Fix build action/ ci-depends-on

* remove runs-on

* update python script

* clean python script

* fix export of booleans

* Fix action

---------

Co-authored-by: Paul Baksic <[email protected]>
@hugtalbot @bakpaul
Update checkPRInfoBeforeBuild.py (#11)
949946a 
* Update checkPRInfoBeforeBuild.py

* Apply suggestions from code review

Co-authored-by: Paul Baksic <[email protected]>

* Apply suggestions from code review

* Apply suggestions from code review

* Test

* Use this script

* fix

* test fromJson

* add debug

* Final fix

* revert change

* Refacto display action

* Fix filter

---------

Co-authored-by: Paul Baksic <[email protected]>
Co-authored-by: Paul Baksic <[email protected]>
@bakpaul
Fix build script (#13)
0ce7781 
* TO BE REVERTED BEFORE MERGE

* Fix syntax

* Fix git handle

* fix action location

* fix typo

* Fix call to load vm env
@bakpaul
fix script + revert wrong changes (#15)
93b612b
@hugtalbot @bakpaul
Update filter-build.yml (#16)
3fab0e2
@hugtalbot @bakpaul
Fix sha when commit pushed in master (#17)
43dcd30
@hugtalbot @bakpaul
Temporarily change remote for non-PR (#18)
9fcf645
@hugtalbot @bakpaul
202505 evolve filter nightly (#19)
867f910 
* Isolate nightly build to allow for matrix only in nightly cases

* Check that SOFA branch name is either master or vXX.XX

* Attempt to detect existing running builds on PR

* Fix check on ci-depends-on

* fix indent and add generic condition for nightly build

* Another fix for ci-depends-on

* Another fix for ci-depends-on in json

* Display info on PR comment

* Display info on PR comment

* Display info on PR comment
@hugtalbot @bakpaul
Fix trigger through comments (#20)
4c5ce49 
* Fix trigger through comments

* remove check when action is already triggered

* remove test comment
hugtalbot and others added 26 commits April 22, 2025 15:21
@hugtalbot @bakpaul
attempt to access information PR comment
070f7ae
@hugtalbot @bakpaul
complete access information PR comment
7dba720
@hugtalbot @bakpaul
complete access information PR comment
8229d83
@hugtalbot @bakpaul
Update search of PR information when comment_issue
37656b4
@hugtalbot @bakpaul
Remove empty env var
06b1e67
@hugtalbot @bakpaul
add check on OWNER_NAME var
9bae225
@hugtalbot @bakpaul
add check on OWNER_NAME var
41dcada
@hugtalbot @bakpaul
last attempt to fill env var for comment_issue
5675c33
@hugtalbot @bakpaul
split in two steps for comment_issue
67db07e
@hugtalbot @bakpaul
add missing PR number for comment_issue (step 2)
384f86c
@bakpaul @hugtalbot
Start work on docker use (#10)
7701642 
* Start work

* Add docker run for ubuntu and fedora

* TOREVERT

* Add insights and login

* Fix action

* Try fix docker autentification

* .github/workflows/

* Add read only token to action

* fix docker user name

* Change pipe to or

* Fix docker call

* try fix docker

* fix ?

* Fix ci-depends-on mechanism

* Fix quote outputed by jq

* Restore branch name

* fix python script

* Fix ci-depends-on remote url

* Fix script not launching

* Display arguments

* Use github env variable for node name

* Unify workspace folder using matrix os

* Add display

* Add display

* Update .github/workflows/filter-build.yml

Co-authored-by: Hugo <[email protected]>

---------

Co-authored-by: Hugo <[email protected]>
@hugtalbot @bakpaul
Filter build only if not schedule, PR comment linked steps (#21)
242503a 
* Filter build only if not schedule, PR comment linked steps

* Apply suggestions from code review

---------

Co-authored-by: Paul Baksic <[email protected]>
@bakpaul
Fix when ci-depends-on is empty (#22)
805ccd6
@bakpaul
Manage out of tree plugins and simplify binaries generation (#23)
6232b5f 
* Manage out of tree plugins and simplify binaries generation

* Add external plugins mechanism
@bakpaul
Fix filter build
9499d7d
@bakpaul
Restore changes
0a14604
@bakpaul
Remove unnecessary checks in workflow dispatch
fd5e726
@bakpaul
Fix builder os matrix
b5f457e
@bakpaul
Fix builder os matrix
daee071
@bakpaul
Activate plugins that are added (#25)
1deb209
@bakpaul
fix adding external repo
398970d
@bakpaul
Force full build on workflow dispatch
93b5b93
@bakpaul @hugtalbot
Add missing inputs to filter build action (#26)
27a49f2 
* Test action

* Fix action

* Test pre job hook

* Add setup_build step

* Fix action

* FIX when folders already exist + TODOS

* Add filter action and scripts

* replace sofa-framework by bakpaul

* fix indentation

* add checkout code action

* Add backbone

* Cloning SOFA working

* Forgot to save

* add chmod to run script

* Add call-workflow, refactor env variables, update python script

* remove useless comment

* Apply suggestions from code review

* Apply suggestions from code review

* Update filter-build.yml

* Finalize clone sofa and ci (#7)

* Push space to creatye PR

* Finished clone sofa and ci stage

* Rename action

* fix some typos in filter script

* Add build step (#8)

* Commit to open a PR

* revert env modification

* Move steps around + add os configuration

* Configure step should be working

* Move comment around

* Step build

* Use step outputs to send variables in call workflow (#9)

* Use step outputs to send variables in call workflow

* add BUILDER_OS environment variable

* add check for all tests in PR body

* remove useless secret

* udpate PR python script

* add missing runs-on: ubuntu-latest

* Fix build action/ ci-depends-on

* remove runs-on

* update python script

* clean python script

* fix export of booleans

* Fix action

---------

Co-authored-by: Paul Baksic <[email protected]>

* Update checkPRInfoBeforeBuild.py (#11)

* Update checkPRInfoBeforeBuild.py

* Apply suggestions from code review

Co-authored-by: Paul Baksic <[email protected]>

* Apply suggestions from code review

* Apply suggestions from code review

* Test

* Use this script

* fix

* test fromJson

* add debug

* Final fix

* revert change

* Refacto display action

* Fix filter

---------

Co-authored-by: Paul Baksic <[email protected]>
Co-authored-by: Paul Baksic <[email protected]>

* Fix build script (#13)

* TO BE REVERTED BEFORE MERGE

* Fix syntax

* Fix git handle

* fix action location

* fix typo

* Fix call to load vm env

* fix script + revert wrong changes (#15)

* Update filter-build.yml (#16)

* Fix sha when commit pushed in master (#17)

* Temporarily change remote for non-PR (#18)

* 202505 evolve filter nightly (#19)

* Isolate nightly build to allow for matrix only in nightly cases

* Check that SOFA branch name is either master or vXX.XX

* Attempt to detect existing running builds on PR

* Fix check on ci-depends-on

* fix indent and add generic condition for nightly build

* Another fix for ci-depends-on

* Another fix for ci-depends-on in json

* Display info on PR comment

* Display info on PR comment

* Display info on PR comment

* Fix trigger through comments (#20)

* Fix trigger through comments

* remove check when action is already triggered

* remove test comment

* move echo to read it

* attempt to access information PR comment

* attempt to access information PR comment

* complete access information PR comment

* complete access information PR comment

* Update search of PR information when comment_issue

* Remove empty env var

* add check on OWNER_NAME var

* add check on OWNER_NAME var

* last attempt to fill env var for comment_issue

* split in two steps for comment_issue

* add missing PR number for comment_issue (step 2)

* Start work on docker use (#10)

* Start work

* Add docker run for ubuntu and fedora

* TOREVERT

* Add insights and login

* Fix action

* Try fix docker autentification

* .github/workflows/

* Add read only token to action

* fix docker user name

* Change pipe to or

* Fix docker call

* try fix docker

* fix ?

* Fix ci-depends-on mechanism

* Fix quote outputed by jq

* Restore branch name

* fix python script

* Fix ci-depends-on remote url

* Fix script not launching

* Display arguments

* Use github env variable for node name

* Unify workspace folder using matrix os

* Add display

* Add display

* Update .github/workflows/filter-build.yml

Co-authored-by: Hugo <[email protected]>

---------

Co-authored-by: Hugo <[email protected]>

* Filter build only if not schedule, PR comment linked steps (#21)

* Filter build only if not schedule, PR comment linked steps

* Apply suggestions from code review

---------

Co-authored-by: Paul Baksic <[email protected]>

* Fix when ci-depends-on is empty (#22)

* Manage out of tree plugins and simplify binaries generation (#23)

* Manage out of tree plugins and simplify binaries generation

* Add external plugins mechanism

* Fix filter build

* Restore changes

* Remove unnecessary checks in workflow dispatch

* Fix builder os matrix

* Fix builder os matrix

* Activate plugins that are added (#25)

* add missing inputs

* fix typo

* Set standard-dev preset for nightly and rename action

* Various cleaning

* Rename action

---------

Co-authored-by: hugtalbot <[email protected]>
@bakpaul @hugtalbot
Add test step (#28)
5be4476 
* Start work on testin

* Temporary change ref in filter build to test this action

* Run unit tests even when with-all-tests is not on

* Fix test launching

* Fix script dir

* Update .github/workflows/filter-build.yml

Co-authored-by: Hugo <[email protected]>

* Apply suggestions from code review

---------

Co-authored-by: Hugo <[email protected]>
@hugtalbot
Fix definition and use of the PYTHONVERSION in steps
4c08e39
@hugtalbot
Fix indent
0f8c58b
@hugtalbot hugtalbot requested a review from bakpaul April 29, 2025 13:28
@bakpaul bakpaul force-pushed the master branch 2 times, most recently from 3357b67 to de725a3 Compare January 5, 2026 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bakpaul bakpaul Awaiting requested review from bakpaul

Assignees

No one assigned

Labels

pr: status to review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hugtalbot @bakpaul