You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
i guess i dont mind supported network test failing cus new chain deployments will be infrequent, but is a tiny bit more work for PR reviewers to realize that 😂
i guess i dont mind supported network test failing cus new chain deployments will be infrequent, but is a tiny bit more work for PR reviewers to realize that 😂
I'm actually wondering if we need that check at all 😬
If we do keep it, CI will bump into this "unrelated issue" whenever there's parallel work happening while launching on a new chain.
I think we need to make sure that the SDK is properly setup for all chains it supports, but not necessarily in sync with the API, right?
If you think it's ok to leave as is, I'd say we should skip the failing test temporarily until the new chain is properly supported by the SDK as well.
@brunoguerios ya i agree prolly best to just remove the test since seem safe to assume we will always be notified when we need to add a new network to SDK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #717 &
test/validateNewChainSetup.test.ts- Refactored to use warnings instead of failures so that ci passes whenever a new chain is rolled out