Drop support for overriding the fetch implementation, requiring native fetch

Change-type: major

Author: Page-

package.json

@@ -47,7 +47,6 @@
     "balena-config-karma": "^4.0.2",
     "chai": "^6.0.1",
     "chai-as-promised": "^8.0.2",
-    "fetch-ponyfill": "^7.1.0",
     "husky": "^9.1.7",
     "karma": "^6.4.4",
     "lint-staged": "^16.1.6",

src/index.ts

@@ -1,17 +1,7 @@
-import type {
-	Params,
-	AnyObject,
-	Resource,
-	AnyResource,
-} from 'pinejs-client-core';
+import type { AnyObject, Resource, AnyResource } from 'pinejs-client-core';
 import { PinejsClientCore } from 'pinejs-client-core';
 export type { PinejsClientCore } from 'pinejs-client-core';
 
-interface BackendParams {
-	/** The browser fetch API implementation or a compatible one */
-	fetch?: typeof fetch;
-}
-
 export class RequestError extends Error {
 	public code = 'PineClientFetchRequestError';
 
@@ -31,21 +21,6 @@ export default class PineFetch<
 		[key in string]: AnyResource;
 	},
 > extends PinejsClientCore<Model> {
-	constructor(
-		params: Params,
-		public backendParams: BackendParams,
-	) {
-		super(params);
-		if (
-			typeof backendParams?.fetch !== 'function' &&
-			typeof fetch !== 'function'
-		) {
-			throw new Error(
-				'No fetch implementation provided and native one not available',
-			);
-		}
-	}
-
 	async _request({
 		url,
 		body,
@@ -61,10 +36,7 @@ export default class PineFetch<
 					? JSON.stringify(body)
 					: body;
 
-		// Assign to a variable first, otherwise browser fetch errors in case the context is different.
-		const fetchImplementation = this.backendParams?.fetch ?? fetch;
-
-		const response = await fetchImplementation(url, {
+		const response = await fetch(url, {
 			...options,
 			body: normalizedBody,
 		});
@@ -78,6 +50,6 @@ export default class PineFetch<
 			}
 			throw new RequestError(responseBody, response.status, response.headers);
 		}
-		return response.json();
+		return await response.json();
 	}
 }

tests/setup.ts

@@ -1,26 +1,15 @@
-import fetchPonyfillFactory from 'fetch-ponyfill';
 import PineFetch from '../build/index.js';
 
 const API_BASE_URL = 'https://api.balena-cloud.com/';
 const API_VERSION = 'v5/';
 
-const IS_BROWSER = typeof window !== 'undefined';
-
-// While testing on a browser, rely on the library to use the native `fetch`.
-const backendParams = IS_BROWSER
-	? {}
-	: { fetch: fetchPonyfillFactory({ Promise }).fetch };
-
 export interface TestSuiteContext extends Mocha.Context {
 	// So that TS lets us type the `this` of `it` calls.
 	pineClient?: PineFetch;
 }
 
 export const givenAPineClient = function (beforeFn: Mocha.HookFunction) {
 	beforeFn(function (this: TestSuiteContext) {
-		this.pineClient = new PineFetch(
-			{ apiPrefix: API_BASE_URL + API_VERSION },
-			backendParams,
-		);
+		this.pineClient = new PineFetch({ apiPrefix: API_BASE_URL + API_VERSION });
 	});
 };