Skip to content

Conversation

@bopete1313
Copy link

Added an option to specify a custom dockerfile with --dockerfile.

@flowzone-app
Copy link
Contributor

flowzone-app bot commented May 21, 2025

A repository maintainer needs to approve this workflow run.

https://github.com/balena-io/deploy-to-balena-action/actions/runs/15172649286

Maintainers, please review all commits and react with 👍 to approve or 👎 to reject.

Things to look for: GitHub Actions Security Cheat Sheet

@bopete1313
Copy link
Author

bopete1313 commented May 21, 2025

Hi,

I followed the changes in the following to guide my changes:
aa666fb

My code does not seem to be working. I changed my docker-compose.yml to docker-compose-test.yml and set the input in my workflow but received:

Error:     Could not detect project type: Service main: package.json: engines.node must be specified
Error:     Not deploying release.
Error: Remote build failed

Did I miss a change somewhere? Any help would be appreciated. Also, please let me know if I'm not following the contribution process correctly, it's my first time.

@bopete1313 bopete1313 changed the title feat: add --dockerfile option to allow specifying custom dockerfiles WIP: add --dockerfile option to allow specifying custom dockerfiles May 21, 2025
@bopete1313
Copy link
Author

bopete1313 commented May 21, 2025

Ah! I've since realized that the --dockerfile option doesn't also work with docker-compose files which was my original goal. I don't really need multiple Dockerfile support right now. I can delete this PR or you guys could keep it and take it from here if you wanted. I just haven't tested Dockerfile's by themselves, we use docker-compose.

Sorry for the noise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant