Fix PATCH /state/v3 not clearing the device's is_running__release #1936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thgreasi
force-pushed
the
state-patch-v3-factory-build
branch
from
2e20650 to
f5fece9
Compare
thgreasi
force-pushed
the
state-patch-v3-factory-build
branch
from
f5fece9 to
0cafe70
Compare
thgreasi
force-pushed
the
state-patch-v3-factory-build
branch
from
0cafe70 to
599a2e3
Compare
Change-type: patch
thgreasi
force-pushed
the
state-patch-v3-factory-build
branch
from
599a2e3 to
4f514ac
Compare
pipex
reviewed
Apr 1, 2025
| : { | ||
| apps: { | ||
| [applicationUuid]: { | ||
| release_uuid: null, |
There was a problem hiding this comment.
Not sure this would ever happen. The release_uuid property would just be undefined
There was a problem hiding this comment.
I realized, but I wanted to make sure that in case we explicitly pass null in this prop, then it is indeed getting stored, b/c that's what makes sense to do any way.
Effectively I treat the supervisor omitting the release_uuid when it's null, just as an optimization, and make sure that the basic semantics work as well (even though we don't expect it to happen).
There was a problem hiding this comment.
Yeah, it makes sense as a test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-type: patch
See: https://balena.fibery.io/Work/Project/Fix-devices-reporting-being-on-the-factory-build-1300
See: #channel/support-help > Return device release to "factory" @ 💬