-
Notifications
You must be signed in to change notification settings - Fork 7
Adapting to newest balena cli version and example repository #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Former folder `single-service-fleet` is now named `single-service-app`.
…retch si no longer available (for the raspberry pi5)
… no longer seems to exist
…as 10 no longer seems to exist
|
A repository maintainer needs to approve these workflow run(s). To approve, maintainers can either: • Submit an approval review on this pull request, OR • Submit a review comment starting with Then re-run the failed job(s) via the Checks tab above. Reviews must be on the specific commit SHA of the workflow run to be considered. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the changes @TheElk205
These changes were made a long time ago to standardize the fleet terminology. We decided to call applications as fleets as documented in this blog post, https://blog.balena.io/the-road-to-multi-app-transitioning-balenacloud-applications-to-fleets/
With that said, the folders are correctly named and should have been named as such since customer applications running on the fleets are releases and services are called app, short for application.
Can you rebase the PR to get new changes from #36
You seem to have missed the commit prefix to signify the change-type for your PR. Please read https://github.com/balena-io/docs/blob/master/CONTRIBUTING.md#creating-commits-in-line-with-semantic-versioning and let us know if you have any further questions. Thanks again.
|
Hello, thank you for the detailed information! Sorry for not checking the documentation first, I was just doing it as I am used to, just to not forget about what I did for myself, initially. Should I rewrite my history, or crate a new fork with the changes again? Best regards |
|
You can rewrite the history, it's still a PR. Squash your commits into one and then force push to the branch in your fork |
I just went through the services masterclass and fixed some things in the documentation that are no longer up to date with the example repository as well as with the current version of the cli.