feat: change historical and engagement exclusions #746
Conversation
There was a problem hiding this comment.
please, unify this migration in dojo/db_migrations/0269_findingexclusion_engagement_findingexclusion_product_and_more.py, updating field engagement to engagements
| label="Engagements" | ||
| ) | ||
|
|
||
| class Meta: |
There was a problem hiding this comment.
delete duplicated class Meta
| cleaned_data = super().clean() | ||
| scope = cleaned_data.get("scope") | ||
|
|
||
| if scope == 'specific': |
There was a problem hiding this comment.
enable scope only when the user is_in_reviewer_group
There was a problem hiding this comment.
add FindingExclusionLog when expire_finding_exclusion_request
There was a problem hiding this comment.
add FindingExclusionLog when expire_finding_exclusion and accept_finding_exclusion_inmediately
There was a problem hiding this comment.
add permission Reopen Finding Exclusion when user is_in_approver_group
| return redirect('finding_exclusions') | ||
|
|
||
|
|
||
| def reopen_finding_exclusion_request(request: HttpRequest, fxid: str) -> HttpResponse: |
There was a problem hiding this comment.
please in function reopen_finding_exclusion_request update status to Accepted
| current_status="Rejected" | ||
| ) | ||
|
|
||
| create_notification( |
There was a problem hiding this comment.
please add maintainer as recipients
| if self.initial.get("practice"): | ||
| self.fields.pop("practice") | ||
|
|
||
| if 'product_type' in self.data: |
There was a problem hiding this comment.
please review if data is limited 25 rows
| </div> | ||
| <div id="vuln_desc" class="panel-body finding-description collapse in"> | ||
| <pre>{{ finding_exclusion.reason }}</pre> | ||
| {% if finding_exclusion.engagements %} |
There was a problem hiding this comment.
validete engagements is not empty
Description
change historical and engagement exclusions
Fix
How does someone fix the issue in code and/or in runtime?
Checklist: