feat: Add N3 examples of MessageBridge usage in JS #7
Conversation
| const nonce = await evmMessageBridge.connect(evmSender) | ||
| .sendExecutableMessage(rawMessage, storeResult, {value: sendingFee, maxFeePerGas, maxPriorityFeePerGas}); | ||
|
|
||
| // Wait until the message arrives on N3... |
There was a problem hiding this comment.
Maybe we could add some wait functionality to the bridge-sdk-ts that allows to just wait here checking the events on the destination chain for the message's nonce.
There was a problem hiding this comment.
I'll make an issue for the SDK. When that's done, I'll add it here as well
There was a problem hiding this comment.
Please comment here linking the issue once opened. Then, we can resolve this comment. We can add this functionality separately later once the feature is implemented in the SDK.
|
|
||
| function exampleFunc() { | ||
| async function exampleFunc() { | ||
| const encodedMessage = getEncodedMessage("0xc28736dc83f4fd43d6fb832Fd93c3eE7bB26828f", "0xabcdefabcdefabcdefabcdefabcdefabcdefabcd"); |
There was a problem hiding this comment.
question: what does getEncodedMessage() do? I know this is out of the context of this pull request, but I feel this could use a better name to make it clear what it does.
There was a problem hiding this comment.
It's actually a method defined lower in the same code block. Maybe we can rename to getBalanceOfCall or something
There was a problem hiding this comment.
I assumed so. Yes, please rename it to make it a bit clearer what it does, you could even use getEncodedBalanceOfCall.
No description provided.