Skip to content

Add DS record support #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Infra-Red wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add DS record support #326

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions bind.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,11 @@ func ConvertBindToRR(record dns.RR) *route53.ResourceRecord {
return &route53.ResourceRecord{
Value: aws.String(value),
}
case *dns.DS:
value := fmt.Sprintf("%d %d %d %s", record.KeyTag, record.Algorithm, record.DigestType, record.Digest)
return &route53.ResourceRecord{
Value: aws.String(value),
}
default:
errorAndExit(fmt.Sprintf("Unsupported resource record: %s", record))
}
Expand Down Expand Up @@ -454,6 +459,28 @@ func ConvertRRSetToBind(rrset *route53.ResourceRecordSet) []dns.RR {
}
ret = append(ret, dnsrr)
}
case "DS":
for _, rr := range rrset.ResourceRecords {
var keyTag uint16
var algorithm uint8
var digestType uint8
var digest string
fmt.Sscanf(*rr.Value, "%d %d %d %s", &keyTag, &algorithm, &digestType, &digest)

dnsrr := &dns.DS{
Hdr: dns.RR_Header{
Name: name,
Rrtype: dns.TypeDS,
Class: dns.ClassINET,
Ttl: uint32(*rrset.TTL),
},
KeyTag: keyTag,
Algorithm: algorithm,
DigestType: digestType,
Digest: digest,
}
ret = append(ret, dnsrr)
}
}
}

Expand Down
26 changes: 26 additions & 0 deletions bind_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,6 +291,32 @@ var testConvertRRSetToBindTable = []struct {
},
},
},
{
Input: route53.ResourceRecordSet{
Type: aws.String("DS"),
Name: aws.String("example.com."),
ResourceRecords: []*route53.ResourceRecord{
{
Value: aws.String("123 4 5 1234567890ABCDEF1234567890ABCDEF"),
},
},
TTL: aws.Int64(86400),
},
Output: []dns.RR{
&dns.DS{
Hdr: dns.RR_Header{
Name: "example.com.",
Rrtype: dns.TypeDS,
Class: dns.ClassINET,
Ttl: uint32(86400),
},
KeyTag: 123,
Algorithm: 4,
DigestType: 5,
Digest: "1234567890ABCDEF1234567890ABCDEF",
},
},
},
{
Input: route53.ResourceRecordSet{
Type: aws.String("NAPTR"),
Expand Down