feat(TBAEF-1634): Add signature discount validator #146
+205
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
✅ Heimdall Review Status
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
amiecorso
reviewed
Oct 29, 2025
Contributor
amiecorso
left a comment
amiecorso
left a comment
There was a problem hiding this comment.
lgtm other than the docs and test nits!
test/discounts/SignatureDiscountValidator/IsValidDiscountRegistration.t.sol
Show resolved
Hide resolved
test/discounts/SignatureDiscountValidator/IsValidDiscountRegistration.t.sol
Outdated
Show resolved
Hide resolved
Co-authored-by: Amie <[email protected]>
Co-authored-by: Amie <[email protected]>
Co-authored-by: Amie <[email protected]>
Collaborator
|
Review Error for amiecorso @ 2025-10-30 22:28:59 UTC |
Co-authored-by: Amie <[email protected]>
…to signature-discount-validator
OGraham-cb
approved these changes
Nov 5, 2025
Collaborator
|
Review Error for OGraham-cb @ 2025-11-05 21:20:27 UTC |
OGraham-cb
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.