Skip to content

Conversation

@kox
Copy link
Contributor

@kox kox commented Oct 17, 2025

gm. while running the tests, I noticed one of the fuzzy tests was failing. following the previous test, I added an extra assumption to skip it for native SOL on Base

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Oct 17, 2025

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 1
Sum 2

@kox kox changed the title include missing assumtion to exclude native sol fix: include missing assumtion to exclude native sol Oct 17, 2025
@jackchuma
Copy link
Collaborator

Hey great catch! We recently removed the SOL_PUBKEY variable from the factory after realizing it was already defined in TokenLib. Can you update this PR to use the TokenLib constant instead?

@kox kox force-pushed the fix/fuzzy-test-missing-assumtion branch from 361dc59 to 818364e Compare October 20, 2025 16:40
@kox
Copy link
Contributor Author

kox commented Oct 20, 2025

Thanks for your review, @jackchuma . Following your recommendation, I switched it to TokenLib.NATIVE_SOL_PUBKEY

@kox kox force-pushed the fix/fuzzy-test-missing-assumtion branch from 818364e to 08673ca Compare October 23, 2025 09:32
@jackchuma jackchuma merged commit c8bcc65 into base:main Oct 23, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants