feat: Add Task Template for Switching Base to a Permissioned Game and Retiring Existing Dispute Games #434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🟡 Heimdall Review Status
|
jackchuma
reviewed
Oct 30, 2025
setup-templates/template-switch-to-permissioned-game/script/SwitchToPermissionedGame.sol
Outdated
Show resolved
Hide resolved
setup-templates/template-switch-to-permissioned-game/script/SwitchToPermissionedGame.sol
Show resolved
Hide resolved
setup-templates/template-switch-to-permissioned-game/script/SwitchToPermissionedGame.sol
Outdated
Show resolved
Hide resolved
setup-templates/template-switch-to-permissioned-game/script/SwitchToPermissionedGame.sol
Outdated
Show resolved
Hide resolved
setup-templates/template-switch-to-permissioned-game/script/SwitchToPermissionedGame.sol
Outdated
Show resolved
Hide resolved
setup-templates/template-switch-to-permissioned-game/script/SwitchToPermissionedGame.sol
Outdated
Show resolved
Hide resolved
setup-templates/template-switch-to-permissioned-game/script/SwitchToPermissionedGame.sol
Outdated
Show resolved
Hide resolved
jackchuma
reviewed
Nov 3, 2025
| string public constant EXPECTED_VERSION = "1.4.1"; | ||
|
|
||
| address public immutable OWNER_SAFE; | ||
| uint64 public currentRetirementTimestamp; |
There was a problem hiding this comment.
currentRetirementTimestamp is unused and can be removed
|
It'd be ideal if this could integrate with the task signer tool as well. Can see an example here: https://github.com/base/contract-deployments/tree/jack/task-signer-tool-demo/mainnet/2025-11-03-test-upgrade |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a way for us to switch base to a permissioned game and retire existing dispute games.
This will require signatures from the OP security council