Skip to content

Conversation

@leopoldjoy
Copy link
Contributor

This PR adds the task for updating the Sepolia incident multi-sig to be in accordance with the latest members of the Base Chain Eng team.

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Nov 3, 2025

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/2
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 2
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 2
2
1 if commit is unverified 0
Sum 2

…the EXISTING_OWNERS_LENGTH constant definition
@leopoldjoy leopoldjoy changed the title Sepolia multisig signers update task [sepolia]: Incident Multisig Update Nov 3, 2025
Copy link
Contributor

@jackchuma jackchuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add the FACILITATORS.md file as well?

OP_COMMIT=bfc4cce53463c0d79224f77c6aba65d7c3f0518b
BASE_CONTRACTS_COMMIT=dcd8c98aa881e0ae4ebf872e0d91692a7bf94000

OWNER_SAFE=0x5dfEB066334B67355A15dc9b67317fD2a2e1f77f
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed this is correct

@@ -0,0 +1,10 @@
OP_COMMIT=bfc4cce53463c0d79224f77c6aba65d7c3f0518b
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this commit coming from? Current version is 594bc933a38425f745b46399a3619bcdeb74965d

@@ -0,0 +1,10 @@
OP_COMMIT=bfc4cce53463c0d79224f77c6aba65d7c3f0518b
BASE_CONTRACTS_COMMIT=dcd8c98aa881e0ae4ebf872e0d91692a7bf94000
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed this is the latest on base/contracts


OWNER_SAFE=0x5dfEB066334B67355A15dc9b67317fD2a2e1f77f

SENDER=0x0CF2F86C3338993ce10F74d6f4B095712c7efe26
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed this is a valid sender


RECORD_STATE_DIFF=true

EXISTING_OWNERS_LENGTH=14
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've done it this way before as well and BlockSec actually preferred to have 14 hardcoded in the script because it's easier to review

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed all addresses here are correct

@@ -0,0 +1,50 @@
# Update Sepolia Incident Multisig Signers

Status: TODO[READY TO SIGN|DONE]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

status should be ready to sign

node --version
```

If you see a version output from the above command, you can move on. Otherwise, install node
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should specify that min version is v18.18


Be sure to select the correct task from the list of available tasks to sign.

### 4. Send signature to facilitator
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could also include a note about killing the signer tool with ctrl + c

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me - however there is a new version of the signer tool that produces an updated format. I'd recommend re-generating this file!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants