Skip to content

chore: rm unused dependencies #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

chore: rm unused dependencies #168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
503bf77
chore: rm unused dep
wlawt Nov 4, 2025
ec8c89a
rm more deps
wlawt Nov 4, 2025
4dd01d6
add workflow
wlawt Nov 4, 2025
e7e1e5e
ignore cli
wlawt Nov 4, 2025
45ebefe
add perms
wlawt Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
name: CI

permissions:
contents: read

on:
push:
branches: [main]
Expand Down Expand Up @@ -68,3 +71,12 @@ jobs:
with:
components: clippy
- run: cargo clippy -- -D warnings

detect-unused-dependencies:
name: Cargo Machete
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v4
- name: Machete
uses: bnjbvr/cargo-machete@main
Copy link
Contributor

@meyer9 meyer9 Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could try using udeps which uses a more in-depth check. This is what upstream reth uses: https://github.com/paradigmxyz/reth/blob/main/.github/workflows/lint.yml#L159-L171

This should have fewer false positives.

69 changes: 0 additions & 69 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 0 additions & 13 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,10 +70,6 @@ reth-db = { git = "https://github.com/paradigmxyz/reth", tag = "v1.8.2" }
reth-testing-utils = { git = "https://github.com/paradigmxyz/reth", tag = "v1.8.2" }
reth-db-common = { git = "https://github.com/paradigmxyz/reth", tag = "v1.8.2" }

# revm
revm = { version = "29.0.0", default-features = false }
revm-bytecode = { version = "6.2.2", default-features = false }

# alloy
alloy-primitives = { version = "1.3.1", default-features = false, features = [
"map-foldhash",
Expand All @@ -84,22 +80,16 @@ alloy-rpc-types = { version = "1.0.41", default-features = false }
alloy-rpc-types-engine = { version = "1.0.41", default-features = false }
alloy-rpc-types-eth = { version = "1.0.41" }
alloy-consensus = { version = "1.0.41" }
alloy-trie = { version = "0.9.1", default-features = false }
alloy-provider = { version = "1.0.41" }
alloy-hardforks = "0.3.5"
alloy-rpc-client = { version = "1.0.41" }
alloy-serde = { version = "1.0.41" }

# op-alloy
op-alloy-rpc-types = { version = "0.20.0", default-features = false }
op-alloy-rpc-types-engine = { version = "0.20.0", default-features = false }
op-alloy-rpc-jsonrpsee = { version = "0.20.0", default-features = false }
op-alloy-network = { version = "0.20.0", default-features = false }
op-alloy-consensus = { version = "0.20.0", default-features = false }

# rollup-boost
rollup-boost = { git = "http://github.com/flashbots/rollup-boost", tag = "rollup-boost/v0.7.5" }
rustls = "0.23.23"

# tokio
tokio = { version = "1.44.2", features = ["full"] }
Expand All @@ -123,10 +113,7 @@ serde_json = "1.0"
url = "2.5"
metrics = "0.24.1"
metrics-derive = "0.1"
itertools = "0.14"
eyre = { version = "0.6.12" }
uuid = { version = "1.6.1", features = ["serde", "v5", "v4"] }
time = { version = "0.3.36", features = ["macros", "formatting", "parsing"] }
chrono = "0.4.41"
brotli = "8.0.1"
arc-swap = "1.7.1"
Expand Down
2 changes: 0 additions & 2 deletions crates/flashblocks-rpc/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,8 @@ reth-optimism-evm.workspace = true
reth-optimism-chainspec.workspace = true
reth-provider.workspace = true
reth-tracing.workspace = true
reth-optimism-cli.workspace = true
reth-primitives.workspace = true
reth-primitives-traits.workspace = true
reth-exex.workspace = true

# alloy
alloy-primitives.workspace = true
Expand Down
7 changes: 2 additions & 5 deletions crates/metering/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ tips-core.workspace = true
# reth
reth.workspace = true
reth-provider.workspace = true
reth-primitives.workspace = true
reth-primitives-traits.workspace = true
reth-evm.workspace = true
reth-optimism-evm.workspace = true
Expand All @@ -35,15 +34,11 @@ alloy-eips.workspace = true
# op-alloy
op-alloy-consensus.workspace = true

# revm
revm.workspace = true

# rpc
jsonrpsee.workspace = true

# misc
tracing.workspace = true
serde.workspace = true
eyre.workspace = true

[dev-dependencies]
Expand All @@ -61,3 +56,5 @@ serde_json.workspace = true
tokio.workspace = true


[package.metadata.cargo-machete]
ignored = ["reth-optimism-cli"]
52 changes: 0 additions & 52 deletions crates/node/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,70 +21,18 @@ base-reth-transaction-tracing.workspace = true
reth.workspace = true
reth-optimism-node.workspace = true
reth-optimism-cli.workspace = true
reth-primitives.workspace = true
reth-rpc-eth-api.workspace = true
reth-optimism-primitives.workspace = true
reth-rpc-convert.workspace = true
reth-optimism-rpc.workspace = true
reth-optimism-evm.workspace = true
reth-optimism-chainspec.workspace = true
reth-cli-util.workspace = true

# revm
revm.workspace = true
revm-bytecode.workspace = true

# alloy
alloy-primitives.workspace = true
alloy-eips.workspace = true
alloy-rpc-types.workspace = true
alloy-rpc-types-engine.workspace = true
alloy-rpc-types-eth.workspace = true
alloy-consensus.workspace = true
alloy-trie.workspace = true
alloy-provider.workspace = true
alloy-hardforks.workspace = true

# op-alloy
op-alloy-rpc-types.workspace = true
op-alloy-rpc-types-engine.workspace = true
op-alloy-rpc-jsonrpsee.workspace = true
op-alloy-network.workspace = true
op-alloy-consensus.workspace = true

# rollup-boost
rollup-boost.workspace = true
rustls.workspace = true

# tokio
tokio.workspace = true
tokio-stream.workspace = true
tokio-tungstenite.workspace = true

# async
futures.workspace = true
futures-util.workspace = true
reqwest.workspace = true

# reth-exex
reth-exex.workspace = true

# rpc
jsonrpsee.workspace = true

# misc
clap.workspace = true
tracing.workspace = true
serde.workspace = true
serde_json.workspace = true
url.workspace = true
metrics.workspace = true
metrics-derive.workspace = true
itertools.workspace = true
eyre.workspace = true
uuid.workspace = true
time.workspace = true
chrono.workspace = true
once_cell.workspace = true

[features]
Expand Down
5 changes: 0 additions & 5 deletions crates/transaction-tracing/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,22 +14,17 @@ workspace = true
# reth
reth.workspace = true
reth-exex.workspace = true
reth-optimism-node.workspace = true
reth-optimism-cli.workspace = true
reth-tracing.workspace = true
reth-primitives.workspace = true

# alloy
alloy-primitives.workspace = true

# async
futures.workspace = true
tokio-stream.workspace = true
tokio.workspace = true

# misc
eyre.workspace = true
lru = "0.16.1"
metrics.workspace = true
metrics-derive.workspace = true
chrono.workspace = true