Skip to content

chore: Fix infinite loop in dependency updater #630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+21 −3
Open

chore: Fix infinite loop in dependency updater #630

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 21 additions & 3 deletions dependency_updater/dependency_updater.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,8 +183,16 @@ func getVersionAndCommit(ctx context.Context, client *github.Client, dependencie
var updatedDependency VersionUpdateInfo
foundPrefixVersion := false
options := &github.ListOptions{Page: 1}
const maxPages = 100 // Prevent infinite loop if API returns unexpected NextPage values
pageCount := 0

if dependencies[dependencyType].Tracking == "tag" {
for {
pageCount++
if pageCount > maxPages {
return "", "", VersionUpdateInfo{}, fmt.Errorf("exceeded maximum page limit (%d) while searching for releases of %s", maxPages, dependencyType)
}

releases, resp, err := client.Repositories.ListReleases(
ctx,
dependencies[dependencyType].Owner,
Expand All @@ -195,6 +203,11 @@ func getVersionAndCommit(ctx context.Context, client *github.Client, dependencie
return "", "", VersionUpdateInfo{}, fmt.Errorf("error getting releases: %s", err)
}

// If no releases found, keep current version
if len(releases) == 0 {
break
}

if dependencies[dependencyType].TagPrefix == "" {
version = releases[0]
if *version.TagName != dependencies[dependencyType].Tag {
Expand All @@ -204,7 +217,7 @@ func getVersionAndCommit(ctx context.Context, client *github.Client, dependencie
break
} else if dependencies[dependencyType].TagPrefix != "" {
for release := range releases {
if strings.HasPrefix(*releases[release].TagName, dependencies[dependencyType].TagPrefix) {
if releases[release].TagName != nil && strings.HasPrefix(*releases[release].TagName, dependencies[dependencyType].TagPrefix) {
version = releases[release]
foundPrefixVersion = true
if *version.TagName != dependencies[dependencyType].Tag {
Expand All @@ -217,9 +230,11 @@ func getVersionAndCommit(ctx context.Context, client *github.Client, dependencie
if foundPrefixVersion {
break
}
// Check if there are more pages before continuing
if resp.NextPage == 0 {
break
}
options.Page = resp.NextPage
} else if resp.NextPage == 0 {
break
}
}
}
Expand Down Expand Up @@ -257,6 +272,9 @@ func getVersionAndCommit(ctx context.Context, client *github.Client, dependencie
if err != nil {
return "", "", VersionUpdateInfo{}, fmt.Errorf("error listing commits for "+dependencyType+": %s", err)
}
if len(branchCommit) == 0 {
return "", "", VersionUpdateInfo{}, fmt.Errorf("no commits found for branch %s in %s (branch may not exist)", dependencies[dependencyType].Branch, dependencyType)
}
commit = *branchCommit[0].SHA
if dependencies[dependencyType].Commit != commit {
diff := dependencies[dependencyType].Commit + " => " + commit
Expand Down