Mobile: Bridge components #2307
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayohms
reviewed
Jan 7, 2026
It sends all buttons in one connect payload.
jayohms
reviewed
Jan 7, 2026
svara
commented
Jan 8, 2026
app/javascript/bridge/controllers/bridge/overflow_menu_controller.js
Outdated
Show resolved
Hide resolved
adjogima
reviewed
Jan 8, 2026
Contributor
|
Considering how we decided to move the app related CSS files into the existing structure, should we do the same here? or even flat, like: |
* main: Fix that caching should be disabled in dev by default. References 3cf841d. Revert "Add CJK (Chinese, Japanese, Korean) search support" Account for new button sizes on mobile Bump filter z-index when filters are open Use a dedicated resource for showing cards in draft mode Refactor popup.css styles for focus state Add Segoe UI Variable Fizzy font face configuration comments Update @layer name to `base` in font-face definition for "Segoe UI Variable Fizzy" Fix font-face `src` reference for "Segoe UI Variable Fizzy" to correct local font lookup Adjust font-weight range for "Segoe UI Variable Fizzy" to include 800-900 Update --font-sans and related font-face references to "Segoe UI Variable Fizzy" for consistency Add "Segoe UI fizzy" to --font-sans and define custom font faces Update --font-sans to include "Segoe UI Variable" for improved text rendering Add margin to details inside popup styles
… board perma since there are duplicate hidden elements
…s is always the same for the bridge message callback
…(for the overflow on the board perma)
* main: Consolidate footer text into a shared partial Tweak comment history button on mobile Transparent lexxy toolbar when inside a golden card Add rel noopener to external links
…rget button can be included
... to fix in the native apps
jayohms
reviewed
Jan 12, 2026
Comment on lines
23
to
29
| receive(message) { | ||
| switch (message.event) { | ||
| case "set-text-size": | ||
| this.setTextSize(message.data) | ||
| break | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
@svara This function is not currently being called within the controller. I think the iOS app is expecting a "connect" or "change" event with this as its callback?
Author
There was a problem hiding this comment.
Good catch! It was leveraging the change event, but I removed it and forgot to fix this. I suggest we add a connect event as we can't rely on the visibility event. What do you think?
Contributor
There was a problem hiding this comment.
Instead of combining unrelated things, how about we rename the "page" component to the "title" component and then you can implement a "text-size" component however you like? Android doesn't need the "text-size" component, so it's a better separation of concerns and its more clear what the components do.
... for template caching
* main: Remove explicit queue definition Fix attribute name Explicitly define incineration priority Fix incorrect recurring job config Add self-service account deletion (#2246) Document DELETE endpoint for removing card header image Document goldness endpoints for marking cards as golden Document closed and column fields in card API response
* main: (22 commits) Disable card column buttons when active Prevent comment content from overlapping with reaction button Delete pins belonging to cards in a board with revoked access Update development dependencies in SAAS lockfile Update runtime dependencies Update development dependencies Balance magic link instructions Add `.txt-balance` utility Move handleDesktop inside restoreColumnsDisablingTransitions Adjust border radius Clean up blank slates Add dialog manager to events page More sturated mini bubbles in light mode Brighten mini bubbles in dark mode Use separate cache namespaces for each beta instance Bump boost size up a tick on mobile Move Undo form inside closure message element Phrasing tweak for exceeding storage limit Keep strong tags words on same line Allow ActionText embed reuse and safe purge (#2346) ...
* main: Add rollback script to convert relative URLs back to absolute Add a script to migrate existing rich texts to relative URLs Use relative URLs where possible across all the app Use relative URLs for avatars and rich text attachments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Hotwire Native Bridge support and components.
Bridge components:
Example usage:
bridged_form_with.Note: CSS has minimal additions to make the examples work.