Hide upload button from default toolbar when attachments is set to false

app/assets/javascript/lexxy.js

@@ -5613,6 +5613,22 @@ class ActionTextAttachmentNode extends gi {
           }),
           priority: 1
         }
+      },
+      "video": (video) => {
+        const videoSource = video.getAttribute("src") || video.querySelector("source")?.src;
+        const fileName = videoSource?.split("/")?.pop();
+        const contentType = video.querySelector("source")?.getAttribute("content-type") || "video/*";
+
+        return {
+          conversion: () => ({
+            node: new ActionTextAttachmentNode({
+              src: videoSource,
+              fileName: fileName,
+              contentType: contentType
+            })
+          }),
+          priority: 1
+        }
       }
     }
   }
@@ -5730,10 +5746,13 @@ class ActionTextAttachmentNode extends gi {
     const figcaption = createElement("figcaption", { className: "attachment__caption" });
 
     const nameTag = createElement("strong", { className: "attachment__name", textContent: this.caption || this.fileName });
-    const sizeSpan = createElement("span", { className: "attachment__size", textContent: bytesToHumanSize(this.fileSize) });
 
     figcaption.appendChild(nameTag);
-    figcaption.appendChild(sizeSpan);
+
+    if (this.fileSize) {
+      const sizeSpan = createElement("span", { className: "attachment__size", textContent: bytesToHumanSize(this.fileSize) });
+      figcaption.appendChild(sizeSpan);
+    }
 
     return figcaption
   }
@@ -8101,6 +8120,7 @@ class LexicalEditorElement extends HTMLElement {
   #createDefaultToolbar() {
     const toolbar = createElement("lexxy-toolbar");
     toolbar.innerHTML = LexicalToolbarElement.defaultTemplate;
+    toolbar.setAttribute("data-attachments", this.supportsAttachments); // Drives toolbar CSS styles
     this.prepend(toolbar);
     return toolbar
   }

app/assets/stylesheets/lexxy-editor.css

@@ -94,6 +94,10 @@
   max-inline-size: 100%;
   padding: 2px;
   position: relative;
+
+  &[data-attachments="false"] button[name="upload"]{
+    display: none;
+  }
 }
 
 :where(.lexxy-editor__toolbar-button) {

src/elements/editor.js

@@ -357,6 +357,7 @@ export default class LexicalEditorElement extends HTMLElement {
   #createDefaultToolbar() {
     const toolbar = createElement("lexxy-toolbar")
     toolbar.innerHTML = LexicalToolbar.defaultTemplate
+    toolbar.setAttribute("data-attachments", this.supportsAttachments) // Drives toolbar CSS styles
     this.prepend(toolbar)
     return toolbar
   }

test/dummy/app/views/posts/_form.html.erb

@@ -11,7 +11,7 @@
   <div>
     <%= form.label :body, style: "display: block" %>
     <%= form.rich_text_area :body, placeholder: "Write something...",
-          attachments: params[:attachments_disabled] ? "false" : nil,
+          attachments: (params[:attachments_disabled] != "true"),
           toolbar: params[:toolbar_disabled] ? "false" : nil, required: true do %>
       <lexxy-prompt trigger="1" empty-results="No results"  name="mention">
         <%= render partial: "people/prompt_item", collection: Person.all, as: :person %>

test/system/toolbar_test.rb

@@ -112,6 +112,26 @@ class ToolbarTest < ApplicationSystemTestCase
     assert_no_selector "lexxy-toolbar"
   end
 
+  test "attachments icon display" do
+    assert_selector "lexxy-toolbar button[name=upload]"
+
+    visit edit_post_path(posts(:empty), attachments_disabled: true)
+
+    assert_no_selector "lexxy-toolbar button[name=upload]"
+
+    visit edit_post_path(posts(:empty), attachments_disabled: false)
+
+    assert_selector "lexxy-toolbar button[name=upload]"
+
+    visit edit_post_path(posts(:empty), attachments_disabled: nil)
+
+    assert_selector "lexxy-toolbar button[name=upload]"
+
+    visit edit_post_path(posts(:empty), attachments_disabled: 'invalid')
+
+    assert_selector "lexxy-toolbar button[name=upload]"
+  end
+
   test "undo and redo commands" do
     # Start with empty editor
     visit edit_post_path(posts(:empty))