- 
                Notifications
    
You must be signed in to change notification settings  - Fork 125
 
fix: Simplify search_notes schema by removing Optional wrappers #395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Changed types and entity_types parameters from Optional[List[str]] to List[str] with empty list defaults. This simplifies the MCP tool schema for better compatibility with Claude Desktop while maintaining backward compatibility through empty list validation. Resolves #392 Co-authored-by: Paul Hernandez <[email protected]>
| 
           Claude finished @phernandez's task —— View job Code Review Complete ✅Review ChecklistCode Quality & Standards
 Testing & Documentation
 Basic Memory Architecture
 Security & Performance
 Detailed ReviewSummaryThis PR successfully simplifies the  Changes AnalysisFile:  Lines 208-209 (Before): types: Optional[List[str]] = None,
entity_types: Optional[List[str]] = None,Lines 208-209 (After): types: List[str] = [],
entity_types: List[str] = [],Line 348 (Comment Update): # Add optional filters if provided (empty lists are treated as no filter)Strengths
 Minor Concerns
 Code Quality AssessmentLine Length: ✅ All lines under 100 characters Tested Scenarios (Verified in Test Suite)All these scenarios are covered by existing tests: 
 Recommendations
 VerdictAPPROVED ✅ This is a clean, minimal fix that: 
 Great work on choosing the simpler solution over the more complex   | 
    
Summary
Resolves #392 - Simplified the search_notes MCP tool schema for better Claude Desktop compatibility.
Changes
types: Optional[List[str]] = None→types: List[str] = []entity_types: Optional[List[str]] = None→entity_types: List[str] = []Benefits
Testing
Reviewed existing tests - all already use list format and are compatible with the new signature.
🤖 Generated with Claude Code