Skip to content

Conversation

@shtouff
Copy link

@shtouff shtouff commented Mar 18, 2023

No description provided.

@batfish-bot
Copy link

This change is Reviewable

@shtouff
Copy link
Author

shtouff commented Mar 18, 2023

according to https://docs.docker.com/engine/reference/commandline/buildx_build/#output, the docker output type for buildx is incompatible with multi-platform images. Therefore, I choose to duplicate build and upload tasks for both images.

@shtouff shtouff changed the title create a docker image for arm64 as well CI: create a docker image for arm64 as well Mar 18, 2023
@dhalperi dhalperi requested a review from sfraint March 20, 2023 15:52
@dhalperi
Copy link
Member

I've asked @sfraint to look at this; he set it up. But I wonder if https://docs.docker.com/build/ci/github-actions/multi-platform/ doesn't imply that we should be able to do two images in one?

@shtouff shtouff force-pushed the shtouff/docker-arm64 branch from 58f4e75 to 2350177 Compare June 4, 2025 18:42
@shtouff
Copy link
Author

shtouff commented Jun 4, 2025

I've asked @sfraint to look at this; he set it up. But I wonder if https://docs.docker.com/build/ci/github-actions/multi-platform/ doesn't imply that we should be able to do two images in one?

you were right, I'm reactivating this PR, tryin to build a single, multi-platform image, using the OCI format.

However, I don't know how to reproduce github actions on my laptop, so it's gonna be a lot a try-and-error, each of them requiring an approval for the workflow. Sorry for that noise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants