Skip to content

Conversation

@beshrislambouli
Copy link
Contributor

closes #796

@beshrislambouli beshrislambouli marked this pull request as ready for review November 2, 2024 17:34
Copy link
Member

@acrantel acrantel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first pr! good job :)

@acrantel
Copy link
Member

acrantel commented Nov 2, 2024

also make sure to run npm run format in the /frontend2 directory to format the files. this is needed to pass the CI:Frontend2 linting in Github

Copy link
Contributor

@lowtorola lowtorola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me other than the one idea i had for automatic error injection into the email link! Please give that a look and then re-request review 😄

Copy link
Contributor

@lowtorola lowtorola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@lowtorola lowtorola merged commit 813cce6 into main Dec 6, 2024
3 checks passed
@lowtorola lowtorola deleted the error-page branch December 6, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error Boundary Prettification

4 participants