Skip to content

Conversation

@jadenPete
Copy link
Contributor

@jadenPete jadenPete commented Oct 28, 2025

Description

This PR is the second in a series to refactor the ruleset to use rules_jvm_external for fetching all Maven artifacts.

It deletes scala/private/extensions/dev_deps.bzl and refactors the ruleset to pull all internal dependencies (previously declared in that module) using rules_jvm_external. It also makes rules_jvm_external a required dependency of the ruleset.

Motivation

Please see this PR for more information on this initiative and the motivations behind it:
#1775

@mbland
Copy link
Collaborator

mbland commented Oct 28, 2025

Quick comments:

I think I'm beginning to see some of the benefit of using rules_jvm_external here. I have a few comments to make, but I'll return to this after the buildifier-prebuilt change lands and this pull request fixes the test_twitter_scrooge_example breakage.

Note that if/when #1785 lands, which should happen first (if we decide to merge it), both the buildifier-prebuilt change and this PR will require rebasing and making MODULE.bazel.lock updates.

@jadenPete
Copy link
Contributor Author

Thank you for the comments! My bad, I've updated the description to follow that format.

Working on splitting out the buildifier-prebuilt changes and fixing the failing test now.

@jadenPete jadenPete force-pushed the jpeterson-use-rules-jvm-external-part-1 branch 5 times, most recently from e3c3f95 to be4fe9f Compare November 3, 2025 18:25
Jaden Peterson added 3 commits November 3, 2025 13:26
It's my goal to remove `dev_deps`, and switching to
`buildifier-prebuilt` gets us one step closer to doing that. It should
also make CI faster.
@jadenPete jadenPete force-pushed the jpeterson-use-rules-jvm-external-part-1 branch from be4fe9f to 917d5f1 Compare November 3, 2025 18:27
@jadenPete
Copy link
Contributor Author

Ok, I've opened a separate PR for the buildifier_prebuilt changes!
#1788

Also, the tests should pass now. That PR needs to be merged before this one, so consider this PR to be stacked on that one and please ignore the first commit when reviewing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants