Skip to content

Conversation

@JazzarKarim
Copy link
Collaborator

@JazzarKarim JazzarKarim commented Feb 7, 2026

Issue:

Description of changes:

  • Table status/filters in both tables uniquely persistent when clicking on logo or back button
  • Filters now not persistent when moving between tables. Example: If I have PR selected in the registrations table and move to the applications table, it shouldn't stay selected
  • Clicking on the clear all filters button in the tables will go back to the default state of that table
  • Moving back from an application or registration (back button or logo button) persists the state of both tables on the dashboard
  • Wired the search text field in the registrations table

I'm testing to the best of my ability all the scenarios... Update: I've tested all the cases, all seems to look good

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the BC Registry and Digital Services BSD 3-Clause License

@JazzarKarim JazzarKarim self-assigned this Feb 7, 2026
@JazzarKarim JazzarKarim force-pushed the 32245-fix-filter-bugs-new-examiner branch from 17ba6ce to 87935d0 Compare February 7, 2026 00:10
@bcgov bcgov deleted a comment from bcregistry-sre Feb 7, 2026
@bcgov bcgov deleted a comment from bcregistry-sre Feb 7, 2026
@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://strr-examiner-dev--pr-1020-zs59q6ef.web.app

@bcgov bcgov deleted a comment from bcregistry-sre Feb 7, 2026
@JazzarKarim JazzarKarim marked this pull request as ready for review February 9, 2026 18:41
@JazzarKarim JazzarKarim force-pushed the 32245-fix-filter-bugs-new-examiner branch from 971eeed to e36b1f1 Compare February 9, 2026 21:19
@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://strr-examiner-dev--pr-1020-zs59q6ef.web.app

Copy link
Collaborator

@dimak1 dimak1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job overall. I added few comments. Also, have you looked at merge by lodash? Maybe it could simplify some of the code...

@JazzarKarim
Copy link
Collaborator Author

Also, have you looked at merge by lodash? Maybe it could simplify some of the code...

Thanks for catching this, changed!

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 9, 2026

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://strr-examiner-dev--pr-1020-zs59q6ef.web.app

@dimak1
Copy link
Collaborator

dimak1 commented Feb 10, 2026

@JazzarKarim thanks for making the updates, LGTM!

@JazzarKarim JazzarKarim merged commit dba4c0c into bcgov:main Feb 10, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants