-
Notifications
You must be signed in to change notification settings - Fork 21
fix: fixed a ton of filtering bugs in new examiner dashboard #1020
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fixed a ton of filtering bugs in new examiner dashboard #1020
Conversation
17ba6ce to
87935d0
Compare
|
Temporary Url for review: https://strr-examiner-dev--pr-1020-zs59q6ef.web.app |
971eeed to
e36b1f1
Compare
|
Temporary Url for review: https://strr-examiner-dev--pr-1020-zs59q6ef.web.app |
dimak1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job overall. I added few comments. Also, have you looked at merge by lodash? Maybe it could simplify some of the code...
strr-examiner-web/app/composables/useExaminerDashboardPersistence.ts
Outdated
Show resolved
Hide resolved
Thanks for catching this, changed! |
|
|
Temporary Url for review: https://strr-examiner-dev--pr-1020-zs59q6ef.web.app |
|
@JazzarKarim thanks for making the updates, LGTM! |



Issue:
Description of changes:
I'm testing to the best of my ability all the scenarios... Update: I've tested all the cases, all seems to look good
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the BC Registry and Digital Services BSD 3-Clause License