Skip to content

Expand Indexlr to use AAHash #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jwcodee wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Expand Indexlr to use AAHash #109

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
eb510eb
aahash: add forward() function to have same member function as nthash
jwcodee Jul 16, 2023
c80bdf2
indexlr.hpp: make indexlr a class template to work with NtHash and AA…
jwcodee Jul 16, 2023
06df701
indexlr: update test
jwcodee Jul 16, 2023
6a78879
indexlr: update wrappers
jwcodee Jul 16, 2023
bc0d02b
indexlr.cpp: WIP for incorprating hashing amino acid seq
jwcodee Jul 16, 2023
aa80a81
indexlr.hpp: move record and minimizer out of class template Indexlr<T>
jwcodee Jul 19, 2023
86d0659
update indexlr unit test
jwcodee Jul 19, 2023
496e543
indexlr.cpp: use std::visit to access indexlr variant to call read()
jwcodee Jul 19, 2023
1ad3c62
indexlr: update wrappers
jwcodee Jul 19, 2023
2399bb3
indexlr: compile wrappers with swig 4.1.1
jwcodee Jul 19, 2023
c82317a
indexlr.cpp: update record during while loop
jwcodee Jul 19, 2023
6ec88cf
indexlr: update wrappers
jwcodee Jul 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions include/btllib/aahash.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,12 @@ class AAHash
size_t get_pos() const { return pos; }
unsigned get_hash_num() const { return hash_num; }
unsigned get_k() const { return k; }
bool
forward() // NOLINT(readability-convert-member-functions-to-static,-warnings-as-errors)
Copy link
Member

@parham-k parham-k Aug 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function is redundant and removed in the latest ntHash. We can remove it here too.

const
{
return true;
}
uint64_t get_forward_hash() const { return hashes_array[0]; }
unsigned get_level() const { return level; }
const char* get_seq() const { return seq; }
Expand Down
Loading