Remove Hash#slice from code. #84
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Did you run the tests locally and do they pass? @hkmaly |
Author
|
Sorry. As I mentioned, they didn't. And by "didn't" I mean I had failures even on tests having nothing to do with the change: 103 runs, 155 assertions, 31 failures, 6 errors, 0 skips including some incorrect encoding and "undefined method `cleanup_tubes!" ... there must be something I did incorrectly or more problems with older ruby than just the ones related to slice. |
Member
|
Hmm okay, thanks for the update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #83