Skip to content

Conversation

@aydrpm
Copy link

@aydrpm aydrpm commented Oct 24, 2025

Description

This PR introduces the foundation for recurring shift management:

  • Add initial models for recurrent shift generator and subscription, with basic views and access rights
  • Use mixins to share common logic between generator and shift models
  • Add new "Registration" parent menu with submenus for "Participation" and "Subscription" (admin-only access)
  • Add configuration settings for shift_nb_occurrence in global settings

Odoo task (if applicable)

Checklist before approval

  • Tests are present (or not needed).
  • Credits/copyright have been changed correctly.
  • Change log snippet is present.
  • (If a new module) Moving this to OCA has been considered.

Fix ensure_one() error in check_remaining_slot when calling
get_booking_status()
- Basic tree views for generator and subscription with generator menu
- Form view for generator
- Menu refactoring with new menu "Registration" and sub-menu
  "Participation" and "Subscription" with admin only access
@aydrpm aydrpm requested a review from remytms October 24, 2025 20:37
@github-grap-bot
Copy link
Contributor

Hi @remytms,
some modules you are maintaining are being modified, check this out!

Copy link
Collaborator

@remytms remytms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great great job. Some very minor changes requested.

- add newline and date fields comment for consistency
- use UserError instead of ValidationError
@aydrpm
Copy link
Author

aydrpm commented Dec 8, 2025

Thanks for the review and the link about errors! All changes applied in commit 9886d11

Copy link
Collaborator

@remytms remytms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@remytms
Copy link
Collaborator

remytms commented Dec 8, 2025

/ocabot merge minor

@github-grap-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-564-by-remytms-bump-minor, awaiting test results.

@github-grap-bot github-grap-bot merged commit 9c81e74 into 16.0 Dec 8, 2025
2 checks passed
@github-grap-bot
Copy link
Contributor

Congratulations, your PR was merged at c1c11ca. Thanks a lot for contributing to beescoop. ❤️

@github-grap-bot github-grap-bot deleted the 16.0-volunteer-shift-generator-base branch December 8, 2025 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants