Fix incorrect default for project_INSTALL_CONFIG_FILE_PACKAGE #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default for this option was supposed to be set to ON by bemanproject/exemplar@19d99a4, hence the commit title "Default generation of CMake config packages to ON". However, due to what I believe is a copypaste bug, that commit set the default to ${PROJECT_IS_TOP_LEVEL} rather than ON, which broke the ability to consume Beman libraries as dependencies. This commit changes the default to ON, which has been tested to address the issue. It also fixes the doc.
ednolan
requested review from
JeffGarland,
neatudarius,
rishyak and
wusatosi
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default for this option was supposed to be set to ON by bemanproject/exemplar@19d99a4, hence the commit title "Default generation of CMake config packages to ON". However, due to what I believe is a copypaste bug, that commit set the default to ${PROJECT_IS_TOP_LEVEL} rather than ON, which broke the ability to consume Beman libraries as dependencies. This commit changes the default to ON, which has been tested to address the issue. It also fixes the doc.