Provide an override for the repo, for disconnected dev #9
Conversation
- Adds yellow color status for partial coverage - Implements consistent decimal formatting for percentages - Extracts color calculation logic to dedicated function - Adding total coverage metrics when --require-all is set This makes it easier to quickly assess code coverage status with clear visual indicators and consistent numerical presentation.
Due to feedback from Beman developers complaining about the noisiness of the warnings produced by markdownlint, at the 2025-06-30 Beman weekly sync the decision was made to disable Markdown linting by default in exemplar. Unlike in exemplar, this commit removes markdown linting entirely from infra, since infra is not a template.
core-reviewers is deprecated.
- this will just affect beman-tidy and won't hurt other folders.
[beman-tidy] add Python linting and formatting to pre-commit
Simple checks to ensure that the top-level LICENSE and README files exist and are not empty.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This reverts commit 0c768a7. This commit passed CI for its pull request but broke CI for main, because the pre-commit CI check only runs on files that differ, whereas the on-merge CI check for main checks all the files in the repository, and some of the files in beman-tidy fail the linter. This commit should be reapplied when `pre-commit run --all-files` succeeds.
- this will just affect beman-tidy and won't hurt other folders.
[beman-tidy] add Python linting and formatting to pre-commit
beman-tidy: implement TOPLEVEL.LICENSE and TOPLEVEL:README
…purpose [beman-tidy] Implement readme.purpose
…ps-names [beman-tidy] Convert missed ALL_CAPS names to lowercase in infra
…RY.TESTS [beman-tidy] Implement directory.tests
Problem ------- It requires to much code with too many accurate details to install a Beman library. Also, repeating those lines of code across many libraries makes it too difficult to maintain installation logic across the project. Solution -------- Create beman_install_library, a CMake function for installing a Beman library. This function uses Beman Standard assumptions to make it simple for Beman libraries to mark themselves for installation.
Add a beman_install_library CMake function
Provide an override URL in, e.g., BEMANINFRA_googletest_REPO for situations where the canonical one in the lockfile won't work.
steve-downey
requested review from
JeffGarland,
ednolan,
neatudarius,
rishyak and
wusatosi
as code owners
There was a problem hiding this comment.
Note that I've suggested that in examplar we should include instead of find_package as originally suggested by Claus. But I don't object to this change.
https://github.com/bemanproject/take_before/blob/main/CMakeLists.txt#L42-L43
|
There's a lot here and github isn't making it easy to review the changes. My only concern after looking at 50 files is file duplication of beman tidy here? Or @neatudarius was that always the plan? Since I'm the least knowledgable on infra here I'll leave it at that. |
Sorry, can you clarify the purpose of this PR? CC: @steve-downey @JeffGarland 
Current status^ is that we don't have beman-tidy in this repo. Why do we want to duplicate this behaviour and to have an always out of that beman-tidy duplicated codebase? Maybe we can find a better solution for the problem. |
|
Something went badly wrong with this PR. It ought to have changed a few lines, not this huge monstrosity. |
|
Was there a force push or something that changed the repo? This looks like it's got an entirely different history? |
|
Closing, per my comments above. |
|
"This branch is 474 commits ahead of and 172 commits behind bemanproject/infra:main." is the proximate cause for how things went wrong, although I don't how I got to that state. |
8 participants
Change the names from "Exemplar"
Provide a variable to override the URL for the repository to fetch from.