Skip to content

Conversation

@HGLRC-T
Copy link
Contributor

@HGLRC-T HGLRC-T commented Nov 12, 2025

Summary by CodeRabbit

  • New Features
    • Added support for the HGLRC H743 Pro/Dual flight controller with full hardware enablement (dual SPI gyros, accelerometers, barometer, magnetometer, onboard flash and OSD).
    • Comprehensive motor/servo/beeper/LED timer and pin mappings for out-of-the-box compatibility.
    • Default blackbox to onboard flash; beeper polarity and default voltage/current meter sources and scales preconfigured.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 12, 2025

Caution

Review failed

Failed to post review comments

Walkthrough

Adds a new HGLRC_H743_DUAL board configuration header for STM32H743: declares board identity and MCU, enables sensors and peripherals (dual IMUs, barometer, flash, MAX7456), and defines pin mappings, SPI/I2C/UART instances, timer-to-pin mapping, DMA option indices, and default meter/blackbox settings.

Changes

Cohort / File(s) Summary
HGLRC_H743_DUAL board configuration
configs/HGLRC_H743_DUAL/config.h
New config header defining BOARD_NAME/MANUFACTURER_ID and STM32H743 target; enables sensors/peripherals (USE_GYRO, USE_ACC, USE_BARO, USE_FLASH, USE_MAX7456); declares pins for beeper, motors 1–8, servos 1–3, UARTs, I2C, LED(s), ADC_vbat/adc_curr; defines SPI/I2C/MAX7456/flash instances and per-gyro CS/EXTI/CLK/ALIGN; provides TIMER_PIN_MAPPING for motors/servos/beeper/LED strip; adds DMA option macros (ADCx_DMA_OPT, TIMUPx_DMA_OPT); sets BARO_I2C_INSTANCE/MAG_I2C_INSTANCE, DEFAULT_BLACKBOX_DEVICE, BEEPER_INVERTED, and default voltage/current meter sources and scales.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

  • Verify STM32H743 peripheral/pin compatibility (timers, SPI, I2C, UART) with assigned pins
  • Check gyro SPI instances, CS/EXTI/CLK assignments and alignment macros
  • Validate TIMER_PIN_MAPPING and DMA option indices against timer channel availability
  • Confirm ADC/voltage/current pin definitions and default meter scales

Possibly related PRs

Suggested reviewers

  • ot0tot
  • haslinghuis
  • nerdCopter

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is completely empty, failing to address any of the mandatory template requirements including schematics review, hardware testing, guideline compliance, or completion of the required checklist. Provide a comprehensive description addressing all mandatory template sections: schematics review status, hardware testing completion, guideline adherence, connector standards compliance, flight testing results, and check off applicable checklist items.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Add HGLRC_H743_DUAL board' clearly and concisely summarizes the main change—adding a new board configuration file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ot0tot
Copy link
Contributor

ot0tot commented Nov 13, 2025

Feedback provided in Discord. Does not follow BF Manufacturer Guidelines.

@HGLRC-T HGLRC-T closed this Dec 16, 2025
@HGLRC-T HGLRC-T reopened this Dec 16, 2025
@HGLRC-T
Copy link
Contributor Author

HGLRC-T commented Dec 17, 2025

I have updated the config.h file of HGLRC_H743_DUAL according to the approved schematic diagram, please check it.

@sugaarK sugaarK added the partner program this pr is for a target from the partner program and will automatically get tier 1 status label Dec 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

partner program this pr is for a target from the partner program and will automatically get tier 1 status

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants