Skip to content

Conversation

@HGLRC-T
Copy link
Contributor

@HGLRC-T HGLRC-T commented Dec 18, 2025

Pull-Request requirements

Mandatory Review for All New Flight Controllers

  • All new flight controllers must undergo the Betaflight review process, regardless of whether they use an existing target.
  • Manufacturers may reuse the same target for multiple designs, but each new hardware release must be reviewed before approval.

Hardware Compliance Requirements

These measures help maintain high standards and ensure compatibility within the Betaflight ecosystem.

If you have any questions or need guidance, feel free to reach out to the Betaflight development team.

Housekeeping

  • Pull-Request only from a custom branch, not master.
  • Replace this text with details of your own.

Checklist (✓/✕, or y/n)

  • passed Betaflight team's schematics review
  • passed hardware samples testing
  • follows guidelines
  • follows connector standards
  • flight tested
  • comments/issues resolved

Summary by CodeRabbit

  • New Features
    • Added support for the HGLRC_F405_S flight controller: full hardware configuration including gyro/accelerometer, barometer, flash storage, OSD, motor/LED timer mappings, UART/I2C/SPI setups, DMA/timer options, default current/voltage meter sources and scales, inverted beeper handling, and a default blackbox device.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 18, 2025

Caution

Review failed

Failed to post review comments

Walkthrough

Adds a new board configuration header for HGLRC_F405_S (STM32F405): defines target MCU/board IDs, enables sensors/peripherals (ICM42688P accel/gyro, DPS368 baro, M25P16 flash, MAX7456 OSD), assigns pins for motors/UARTs/I2C/SPI/LEDs/beeper/ADCs, sets TIMER_PIN_MAPPING and DMA/I2C/SPI instances, and meter defaults.

Changes

Cohort / File(s) Summary
HGLRC_F405_S Board Configuration
configs/HGLRC_F405_S/config.h
New config header: sets FC_TARGET_MCU, BOARD_NAME, MANUFACTURER_ID; enables peripherals (USE_GYRO, USE_ACC, USE_BARO, USE_FLASH, USE_MAX7456, specific IC variants); detailed pin mappings for beeper, motors, UARTs, I2C, LEDs, SPI, gyro, flash, ADCs and misc; defines TIMER_PIN_MAPPING, DMA options, I2C/SPI instance mappings, default current/voltage meter sources/scales, inverted beeper flag, and blackbox device default.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Verify pin mappings vs. HGLRC_F405_S schematic (motors, UARTs, I2C, SPI, ADCs).
  • Check TIMER_PIN_MAPPING, DMA settings, and timer/channel assignments for STM32F405 compatibility.
  • Confirm enabled peripherals (ICM42688P, DPS368, M25P16, MAX7456) match board BOM and required instances.

Possibly related PRs

Suggested reviewers

  • haslinghuis
  • ot0tot
  • nerdCopter

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The description contains only the template text without any author-provided details about the specific board submission, failing to replace placeholder text with actual PR-specific information. Replace the template text with specific details about the HGLRC_F405_S board submission and update the checklist to indicate which review criteria have been met.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Add HGLRC_F405_S board' clearly and directly describes the main change - adding a new board configuration file for the HGLRC_F405_S flight controller.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sugaarK sugaarK added the partner program this pr is for a target from the partner program and will automatically get tier 1 status label Dec 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

partner program this pr is for a target from the partner program and will automatically get tier 1 status

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants