Add BorderRadius to Node
#21781
Merged
Add BorderRadius to Node
#21781
+171
−129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Instead add a `border_radius: BorderRadius` field to `Node`.
hukasu
added
A-UI
Contributor
|
It looks like your PR is a breaking change, but you didn't provide a migration guide. Please review the instructions for writing migration guides, then expand or revise the content in the migration guides directory to reflect your changes. |
ickshonpe
added
D-Straightforward
alice-i-cecile
approved these changes
Nov 10, 2025
Member
|
@rossleonardy, could I get your review here please? |
rossleonardy
approved these changes
Nov 10, 2025
Contributor
rossleonardy
left a comment
rossleonardy
left a comment
There was a problem hiding this comment.
Pleased with this outcome !
alice-i-cecile
added
S-Ready-For-Final-Review
mockersf
approved these changes
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
There was discussion in the
Next Generation Scene/UIabout addingBackgroundColortoNode. I don't know about that, but it reminded me that border radius isn't part ofNode. All the other properties that affect aNode's shape are there, border radius should be there too.Solution
border_radius: BorderRadiusfield.Componentderive fromBorderRadius.Testing
The internal changes are relatively trivial. There could be mistakes in the examples though, because of the large number of changes.