-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Allow deprecated heapless::mpmc to fix no_std builds
#21818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| target_has_atomic = "64", | ||
| target_has_atomic = "ptr" | ||
| )))] | ||
| #[allow(deprecated)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might have to allow allow_attribute
| use core::cell::Cell; | ||
|
|
||
| use bevy_tasks::{block_on, futures_lite::{pending, poll_once}}; | ||
| use bevy_tasks::{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weird unrelated change. I expect that rustfmt prevents this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this is actually because this file wasnt rustfmt-ed for some reason.
|
the no std job is not required by CI so its failures are not blocking, and the deprecation is used there to mark a real issue. I would prefer to have the investigation in #21819 from their doc:
and
So it's not actually deprecated, but used to mark that it doesn't work as expected in some cases |
Objective
heaplessjust deprecated theirmpmcmodule in a minor version, which broke ourno_stdbuilds (because we choose to break our break our builds on warnings).rust-embedded/heapless#583
https://docs.rs/heapless/latest/heapless/mpmc/index.html
Solution
Short term, fix our builds by allowing this usage of a deprecated function. However it is worth investigating: #21819