Add RtBrick config support for prefix lists #129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djinh
commented
Apr 29, 2025
djinh
commented
- Picked -x as there aren't many arguments still free
added 2 commits
April 29, 2025 15:22
- rename NOKIA_SRL_IPFILTER_PARAMS to SEQUENCE_NUMBER_PARAMS to reuse
job
reviewed
May 26, 2025
| #include "sx_report.h" | ||
|
|
||
| extern int debug_expander; | ||
| static int needscomma = 0; |
Member
There was a problem hiding this comment.
instead of a global variable, can you use a function-scope-specific int nc (like other printer functions do)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.