-
Notifications
You must be signed in to change notification settings - Fork 147
BEP038: Atlas examples #501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
I don't think this should be a problem.
Gotcha, will give them content.
desc then? |
Sounds good to me. |
| { | ||
| "Name": "Harvard-Oxford Subcortical Probabilistic Atlas", | ||
| "SampleSize": 200, | ||
| "SpatialReference": "", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have this empty because the SpatialReference depends on the resolution and this atlas is available in res-01 and res-02. Also, the SpatialReference should be present in the individual sidecar JSONs.
| "https://github.com/PennLINC/AtlasPack" | ||
| ], | ||
| "SampleSize": "n/a", | ||
| "SourceAtlases": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't in the BEP or the spec, but it seems like we should have something like it.
Use LabelMap JSON field instead.
Add BEP038-compliant atlas examples of commonly used publicly available atlases
This branch implements examples according to bids-standard/bids-specification#1714 (rendered: https://bids-specification--1714.org.readthedocs.build/en/1714/).
Please make PRs against the
bep038branch, and we will merge this PR as a part of merging BEP038.xref bids-standard/bids-validator#288