-
Notifications
You must be signed in to change notification settings - Fork 147
ENH: add ability to test examples PR against PR in bids-specification #515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yarikoptic
wants to merge
10
commits into
bids-standard:master
Choose a base branch
from
yarikoptic:enh-bids-pr-test
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
8bb8fc8
ENH: allow to test against bids-spec PR schema.
yarikoptic 8fa6f5d
Add rudimentary pull_requests_template.md with syntax to list bids-sp…
yarikoptic 4d07be2
CI: trigger workflow on PR description edits
yarikoptic e0d76c7
CI: fix workflow syntax errors for bids-pr matrix
yarikoptic 08b9d61
CI: fix PR body parsing to handle special characters
yarikoptic 539efa1
noop if no match
yarikoptic 0777172
default to NONE for PRs and add validator PR
yarikoptic a76de45
Adjust for the rename of the tag in prior PR + rename run to bids-prs
yarikoptic de7e985
Install if needed custom bids-validator and also adjust installation …
yarikoptic 03622a8
Use gh cli for API calls to avoid rate limiting on macOS
yarikoptic File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| <!-- New examples often relate to in-progress changes to the specification or validator. Link to the relevant PRs, if any. --> | ||
|
|
||
| - BIDS Specification PR: NONE | ||
| - BIDS Validator PR: NONE | ||
| - TODOs: | ||
| - [ ] ... | ||
|
|
||
| <!-- PLEASE READ AND DELETE THE TEXT BELOW BEFORE OPENING THE PULL REQUEST --> | ||
|
|
||
| See the [CONTRIBUTING](https://github.com/bids-standard/bids-examples/blob/master/CONTRIBUTING.md) guide. Specifically: | ||
|
|
||
| - Please keep the title of your Pull Request (PR) short but informative - it will appear in the changelog. | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would either deactivate
devor just updatedevsteps to use your environment variables.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why to collide the two making it to change meaning of a CI run? "explicit better than implicit", so I would have just added one dedicated run so if
devpasses somehow -- should alert people if they expect non-released bids-specification to failThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I called it
dev-prsnow to reflect the fact that we still usedevversion of validator even if no PR is given for it.