-
Notifications
You must be signed in to change notification settings - Fork 190
[ENH] provide RECOMMENDATION of the "Last, First" form for the Authors names
#2255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
… names
ATM there is no consistency across e.g. OpenNeuro datasets, e.g.
ds006267/dataset_description.json:
Authors=['Katherine M. Cole', 'Shau-Ming Wei', 'Pedro E. Martinez', 'Tuong-Vi Nguyen', 'Michael D. Gregory', 'J. Shane Kippenhan', 'Philip D. Kohn', 'Steven J. Soldin', 'Lynnette K. Nieman', 'Jack A. Yanovski', 'Peter J. Schmidt', 'Karen F. Berman']
ds006269/dataset_description.json:
Authors=['Lucy Pritchard', 'Ingrid Buller-Peralta', 'Sally M Till', 'Peter C Kind', 'Alfredo Gonzalez-Sulser']
ds006303/dataset_description.json:
Authors=['Linke, Julia', 'Naim, Reut', 'Haller, Simone', 'Khosravi, Parmis', 'Scheinberg, Beck', 'Byrne, Meghan', 'Harrewijn, Anita', 'Leibenluft, Ellen', 'Brotman, Melissa', 'Winkler, Anderson', 'Pine, Daniel']
and that is why some are left ambigous like
ds003834/dataset_description.json:
Authors=['Matteo Visconti di Oleggio Castello', 'James V. Haxby', 'M. Ida Gobbini']
where for Matteo I believe there is a composite last name of "Visconti di Oleggio Castello" per e.g.
❯ curl --silent https://raw.githubusercontent.com/bids-standard/pybids/refs/heads/main/.zenodo.json | grep Matteo
"name": "Visconti di Oleggio Castello, Matteo",
Regex? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2255 +/- ##
=======================================
Coverage 82.83% 82.83%
=======================================
Files 20 20
Lines 1672 1672
=======================================
Hits 1385 1385
Misses 287 287 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I could support a warning for inconsistent comma usage, if any entry in Would any one head this warning given the current noise in the output? |
I must have been too tired! ;) the question is now "how". I thought now that most logical would be to add "format" which I pushed, but that might be too restrictive leading to ERRORs right away? Otherwise, we need some custom rule which would use |
3c89d12 to
3e50942
Compare
3e50942 to
53e86b7
Compare
|
Ha -- so we are not testing against "known to be ok" https://github.com/bids-standard/bids-examples/ which I assume I have broken here? @effigies WDYT -- wouldn't it be worth testing against some "release" (known to be good) of the bids-examples thus preventing "regressions" (prior valid becomes invalid) in the specifications? |
ATM there is no consistency across e.g. OpenNeuro datasets, e.g.
and that is why some are left ambigous like
where for Matteo I believe there is a composite last name of "Visconti di Oleggio Castello" per e.g.
but for the other 2 authors, the only last word is the Family name.
TODOs
First Last, in particular if any of the names has more than 2 components? @effigies do you see an easy way to do that?