Skip to content

Add #[SensitiveParameter] attribute. #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
donquixote wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Add #[SensitiveParameter] attribute. #285

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/BigBlueButton.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,8 +92,12 @@ class BigBlueButton
/**
* @param null|array<string, mixed> $opts
*/
public function __construct(?string $baseUrl = null, ?string $secret = null, ?array $opts = [])
{
public function __construct(
?string $baseUrl = null,
#[\SensitiveParameter]
?string $secret = null,
?array $opts = [],
) {
// Provide an early error message if configuration is wrong
if (is_null($baseUrl) && false === getenv('BBB_SERVER_BASE_URL')) {
throw new \RuntimeException('No BBB-Server-Url found! Please provide it either in constructor '
Expand Down
14 changes: 10 additions & 4 deletions src/Util/UrlBuilder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,16 +47,22 @@ class UrlBuilder

private string $baseUrl;

public function __construct(string $secret, string $baseUrl, HashingAlgorithm $hashingAlgorithm)
{
public function __construct(
#[\SensitiveParameter]
string $secret,
string $baseUrl,
HashingAlgorithm $hashingAlgorithm,
) {
$this->setSecret($secret);
$this->setBaseUrl($baseUrl);
$this->setHashingAlgorithm($hashingAlgorithm);
}

// Getters & Setters
public function setSecret(string $secret): self
{
public function setSecret(
#[\SensitiveParameter]
string $secret,
): self {
$this->secret = $secret;

return $this;
Expand Down