Feature: Support Scopes for Artifacts #153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #97 #147
Overview
This PR introduces the feature of supporting Scopes in artifacts, mostly checked through Ghidra. Issues #97 and #147 best describe why this is needed, but the difficulty comes from other decompilers NOT supporting scopes for types, unlike Ghidra.
To fix these issues took some hard engineering to support scopes as an optional feature across all of libbs. That means if a normal decompiler gets the scoped type, it should still work. And if Ghidra<-> Ghidra has it, it should be high fidelity.
For more info, see the diff.
Tasks