Update pyo3 and numpy crate versions to support python 3.13#21
Update pyo3 and numpy crate versions to support python 3.13#21padix-key merged 5 commits intobiotite-dev:mainfrom
Conversation
CodSpeed Performance ReportMerging #21 will improve performances by 26.1%Comparing 🎉 Hooray!
|
| Benchmark | BASE |
HEAD |
Change | |
|---|---|---|---|---|
| ⚡ | test_read |
2.1 ms | 1.6 ms | +26.1% |
|
I'm not sure if the test failures are due to something that I changed. It looks like there might be a missing github action? |
Okay, all fixed up! I'm not sure if the modifications to the upload step I made are correct though, @padix-key would you mind checking to make sure I didn't make any mistakes? |
|
The benchmarks might also be misleading, since I swapped the CI to start using python 3.13 instead of 3.12. I'm not entirely familiar with github's CI though, so maybe the benchmarks are being run with 3.13 in both the "before" and "after" state, in which case it's a fair comparison. |
padix-key
left a comment
There was a problem hiding this comment.
Thanks for updating the build pipeline, the changes look correct to me! Below I only propose another small change
Sorry for the late response, the PR slipped through my attention.
so maybe the benchmarks are being run with 3.13 in both the "before" and "after" state
No, the benchmarks compare this CI run (with Python 3.13) with the latest CI run on main (with Python 3.12). So the results of the benchmarks shows that Python 3.13 is significantly faster in some tasks
|
I've made the recommended suggested change, but modified it to look for any numpy version 1.26.x, because for some reason pip is failing to find 1.26 specifically. |
|
There is currently a segmentation fault in the CI when executing |
Should we try just re-triggering the pipeline? I'm not sure what the best way is to gain confidence that this is purely spurious and not a real issue with the code. That being said, you're right: It does seem to specifically be pytest that's segfaulting. |
Looks like reverting the latest commit fixes things. I'll remove the extra commits and force-push back to where it was succeeding. |
|
I think the assets failed to upload in the release after this PR was merged. |
|
This oversight is caused by a previous PR. #22 will fix it |
Support for python 3.13 was added to PyO3 in version 0.22. The main purpose of this PR is to add this support to fastpdb.
Additionally I bumped the version of the numpy crate to pick up the latest changes. This is optional though, and if you think there are any problems with this I can remove the update.