pad short lines when reading from non-file io#24
Merged
padix-key merged 2 commits intobiotite-dev:mainfrom May 27, 2025
Merged
Conversation
This makes the behavior using io.StringIO match the behavior when reading from a file
Member
|
Hi, thanks for the contribution. In general I think this is a good idea. Let's wait for the CI to see the performance impact on this. As alternative we could also justify the line on the Rust side, if the impact is measurable. |
Contributor
Author
|
I had originally put this in the constructor on the rust side but then I didn't want to make it happen twice in the more common |
Member
Now I understand what you mean, I forgot that these lines existed. Lines 76 to 78 in 64d6b14 In this case this seems like a sensible solution to me, thanks 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the behavior match between reading from
io.StringIOand reading from a file.