Update about logo icon (colour) to denote the chain type of the QT instance in About/ Help Message Window/ Dialog #762

pablomartin4btc · 2023-09-25T00:03:25Z

It fixes #761.

About logo icon is updated now with the correct colour indicating the chain type of the QT instance that user is running (as the splash screen), plus the title of the about window also is updated with the chain type string as in the main window.

Before PR changes screenshot

After PR changes screenshot

Current splash screen screenshot

(this hasn't been touched, just to show consistency with this PR changes)

Tested it also with:

mainnet (no command line args after bitcoin-qt or bitcoin-qt -chain=main),
-regtest and
-testnet.

DrahtBot · 2023-09-25T00:03:27Z

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type	Reviewers
Concept ACK	hernanmarino, laanwj
Stale ACK	BrandonOdiwuor

If your review is incorrectly listed, please copy-paste  into the comment that the bot should ignore.

Conflicts

No conflicts as of last run.

LLM Linter (✨ experimental)

Possible typos and grammar issues:

"Create a message box, because the gui has neither been created nor has subscribed to core signals" -> "Create a message box, because the gui has neither been created nor has it subscribed to core signals." [Missing pronoun "it" makes the second clause ungrammatical; adding "it" fixes the subject for "has subscribed."]

No other typographic or grammatical errors affecting comprehension were found.

^2025-12-03

maflcko

It may help to show screenshots before and after

maflcko · 2023-10-05T14:03:26Z

src/qt/utilitydialog.cpp

+void HelpMessageDialog::setAboutWindowTitle(const NetworkStyle *networkStyle)
+{
+    QString aboutTitle = tr("About %1").arg(PACKAGE_NAME);
+    if ((networkStyle) && (Params().GetChainType() != ChainType::MAIN)) aboutTitle.append(" " + networkStyle->getTitleAddText());


Why would this be nullptr? Seems easier to use a reference that is never null?

I didn't want to touch src/qt/bitcoin.cpp:

gui/src/qt/bitcoin.cpp

Line 568 in db19a7e

HelpMessageDialog help(nullptr, gArgs.IsArgSet("-version"));

And I also needed to move where the networkStyle is initialised/ set before the HelpMessageDialog constructor:

gui/src/qt/bitcoin.cpp

Line 607 in db19a7e

QScopedPointer<const NetworkStyle> networkStyle(NetworkStyle::instantiate(Params().GetChainType()));

But I can do it if that's better.

pablomartin4btc · 2023-10-05T14:38:16Z

It may help to show screenshots before and after

Thanks for your review @MarcoFalke, the before screenshot is on the issue #761 but I can bring it here if that makes it clearer.

hernanmarino

tested ACK

pablomartin4btc · 2023-10-07T19:34:46Z

It may help to show screenshots before and after

@maflcko I've updated the description with your suggestion (copied @furszy's style from his PR #764, I find it less invasive for the reviewer)

MarnixCroes

tack 30c235b

src/qt/utilitydialog.cpp

BrandonOdiwuor

Concept ACK

BrandonOdiwuor

Tested ACK 30c235b

hebasto · 2024-02-12T14:00:55Z

@GBKS What do you think from a designer's point of view?

maflcko · 2024-02-12T14:13:15Z

Not sure. All info displayed on the About page is fixed details about the software itself, not about the current (test)chain. So modulating the icon or title bar seems confusing, but no strong opinion.

GBKS · 2024-02-15T12:30:24Z

Definitely more consistent this way.

hebasto · 2024-02-15T13:22:10Z

Not sure. All info displayed on the About page is fixed details about the software itself, not about the current (test)chain.

In that case, shouldn't the logo on the About page be black-toned?

pablomartin4btc · 2024-08-25T19:16:04Z

Updates:

Addressed @hebasto's feedback.
Fixed the error message window inconsistency detected by @hebasto above.

Now running qt from the command line with bitcoin-qt.exe -signet -about (or similar command with an invalid argument) will show the correct chain type icon at the top left of the title bar (this is only happening in Windows at the moment).

pablomartin4btc · 2025-01-31T14:50:51Z

Rebased.

laanwj · 2025-10-23T15:00:45Z

Concept ACK

src/qt/utilitydialog.cpp

src/qt/bitcoingui.cpp

src/qt/bitcoin.cpp

Adding the networkStyle parameter to the HelpMessageDialog creator on utilitydialog, updating all calls where its instance is being created from bitcoingui.cpp. In the object itself, use this new parameter object to build the about window title and set the icon of the about logo widget.

Introducing a new helper GUIUtil::ShowMessageBox() in order to incorporate the chaintype image in the message box window icon.

pablomartin4btc · 2025-12-03T15:16:01Z

Updates:

Addressed @laanwj's feedback.

Reworked the error message window inconsistency fix detected by @hebasto above, applying it to most QMessageBox possible instances in bitcoin.cpp and separating it in the 2nd commit for clarity and in case it needs to be dropped because it's getting out of scope or extended to other files (perhaps a follow-up in a separate PR).

Message-box window icon behavior is inconsistent across platforms: some X11 window managers and many Wayland compositors ignore message-box icons entirely. With the new GUIUtil::ShowMessageBox() helper, we can instead explicitly set QIcon() (no icon) and avoid constructing a NetworkStyle just for dialogs or checking whether a ChainType was passed.
(Windows behavior still needs to be re-checked under Qt 6 — to confirm whether the no-icon option is effectively applied.)

--- a/src/qt/guiutil.cpp
+++ b/src/qt/guiutil.cpp
@@ -1012,7 +1012,6 @@ void ShowModalDialogAsynchronously(QDialog* dialog)
 
 void ShowMessageBox(const QString& message,
                             QMessageBox::Icon box_icon,
-                            const NetworkStyle* network_style,
                             const QString& title)
 {
     QString qTitle = CLIENT_NAME;
@@ -1021,14 +1020,7 @@ void ShowMessageBox(const QString& message,
 
     mBox.setTextFormat(Qt::PlainText);

-    if (network_style) {
-        mBox.setWindowIcon(network_style->getTrayAndWindowIcon());
-    } else if (!gArgs.GetChainTypeString().empty()) {
-        std::unique_ptr<const NetworkStyle> fallback(NetworkStyle::instantiate(gArgs.GetChainType()));
-        if (fallback) {
-            mBox.setWindowIcon(fallback->getTrayAndWindowIcon());
-        }
-    }
+    mBox.setWindowIcon(QIcon());

     mBox.exec();
 }

DrahtBot added CI failed and removed CI failed labels Sep 25, 2023

pablomartin4btc force-pushed the gui-update-about-logo-icon branch from 7398ef4 to 30c235b Compare September 25, 2023 02:21

maflcko reviewed Oct 5, 2023

View reviewed changes

hernanmarino approved these changes Oct 6, 2023

View reviewed changes

MarnixCroes approved these changes Nov 2, 2023

View reviewed changes

DrahtBot mentioned this pull request Nov 14, 2023

getrawtransaction implementation #777

Closed

kristapsk reviewed Dec 27, 2023

View reviewed changes

src/qt/utilitydialog.cpp Outdated Show resolved Hide resolved

BrandonOdiwuor reviewed Dec 28, 2023

View reviewed changes

BrandonOdiwuor approved these changes Dec 28, 2023

View reviewed changes

DrahtBot requested review from hernanmarino and removed request for hernanmarino December 28, 2023 13:38

DrahtBot added the CI failed label Jan 14, 2024

DrahtBot requested review from hernanmarino and removed request for hernanmarino February 12, 2024 14:00

DrahtBot requested review from hernanmarino and removed request for hernanmarino February 12, 2024 14:13

maflcko mentioned this pull request Feb 13, 2024

About logo icon doesn't denote chain type (?) in About/ Help message window/ dialog #761

Open

1 task

DrahtBot requested review from hernanmarino and removed request for hernanmarino February 15, 2024 12:30

DrahtBot requested review from hernanmarino and removed request for hernanmarino February 15, 2024 13:22

pablomartin4btc force-pushed the gui-update-about-logo-icon branch from 577d500 to 5556860 Compare August 25, 2024 19:02

DrahtBot removed the CI failed label Aug 25, 2024

This was referenced Oct 11, 2024

refactor: Clean up messy strformat and bilingual_str usages bitcoin/bitcoin#31072

Merged

build: Rename PACKAGE_* variables to CLIENT_* bitcoin/bitcoin#31042

Merged

util: Check bilingual_str format strings at compile time bitcoin/bitcoin#31074

Closed

DrahtBot mentioned this pull request Oct 25, 2024

build: Switch to Qt 6 bitcoin/bitcoin#30997

Merged

DrahtBot added the Needs rebase label Oct 28, 2024

pablomartin4btc force-pushed the gui-update-about-logo-icon branch from 5556860 to 036f070 Compare January 31, 2025 13:19

DrahtBot removed the Needs rebase label Jan 31, 2025

achow101 requested review from davidgumberg and laanwj and removed request for hernanmarino October 22, 2025 14:32

laanwj reviewed Oct 23, 2025

View reviewed changes

src/qt/utilitydialog.cpp Outdated Show resolved Hide resolved

laanwj reviewed Oct 23, 2025

View reviewed changes

src/qt/bitcoingui.cpp Outdated Show resolved Hide resolved

laanwj reviewed Oct 23, 2025

View reviewed changes

src/qt/bitcoin.cpp Outdated Show resolved Hide resolved

pablomartin4btc force-pushed the gui-update-about-logo-icon branch 2 times, most recently from f189e8b to 6287b64 Compare December 3, 2025 01:42

DrahtBot added the CI failed label Dec 3, 2025

pablomartin4btc force-pushed the gui-update-about-logo-icon branch 4 times, most recently from 4612c5f to 5648658 Compare December 3, 2025 04:29

DrahtBot removed the CI failed label Dec 3, 2025

pablomartin4btc added 2 commits December 3, 2025 10:43

gui: Update QMessageBox::Icon with chaintype image

da44744

Introducing a new helper GUIUtil::ShowMessageBox() in order to incorporate the chaintype image in the message box window icon.

pablomartin4btc force-pushed the gui-update-about-logo-icon branch from 5648658 to da44744 Compare December 3, 2025 13:43

Update about logo icon (colour) to denote the chain type of the QT instance in About/ Help Message Window/ Dialog #762

Are you sure you want to change the base?

Update about logo icon (colour) to denote the chain type of the QT instance in About/ Help Message Window/ Dialog #762

Uh oh!

Conversation

pablomartin4btc commented Sep 25, 2023 • edited by hebasto Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DrahtBot commented Sep 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviews

Conflicts

LLM Linter (✨ experimental)

Uh oh!

maflcko left a comment

Choose a reason for hiding this comment

Uh oh!

maflcko Oct 5, 2023

Choose a reason for hiding this comment

Uh oh!

pablomartin4btc Oct 5, 2023

Choose a reason for hiding this comment

Uh oh!

pablomartin4btc commented Oct 5, 2023

Uh oh!

hernanmarino left a comment

Choose a reason for hiding this comment

Uh oh!

pablomartin4btc commented Oct 7, 2023

Uh oh!

MarnixCroes left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

BrandonOdiwuor left a comment

Choose a reason for hiding this comment

Uh oh!

BrandonOdiwuor left a comment

Choose a reason for hiding this comment

Uh oh!

hebasto commented Feb 12, 2024

Uh oh!

maflcko commented Feb 12, 2024

Uh oh!

GBKS commented Feb 15, 2024

Uh oh!

hebasto commented Feb 15, 2024

Uh oh!

pablomartin4btc commented Aug 25, 2024

Uh oh!

pablomartin4btc commented Jan 31, 2025

Uh oh!

laanwj commented Oct 23, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pablomartin4btc commented Dec 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

pablomartin4btc commented Sep 25, 2023 •

edited by hebasto

Loading

DrahtBot commented Sep 25, 2023 •

edited

Loading