Migrate plistutil to v2 #299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
godrei
commented
Nov 10, 2025
| g.logger.Warnf("Filtering CodeSignInfo groups for target capabilities") | ||
|
|
||
| codeSignGroups = export.FilterSelectableCodeSignGroups(codeSignGroups, export.CreateEntitlementsSelectableCodeSignGroupFilter(bundleIDEntitlementsMap)) | ||
| codeSignGroups = export.FilterSelectableCodeSignGroups(codeSignGroups, export.CreateEntitlementsSelectableCodeSignGroupFilter(convertToV1PlistData(bundleIDEntitlementsMap))) |
Contributor
Author
There was a problem hiding this comment.
export package is on V1 and uses V1 plistutil, until we migrate export package convertToV1PlistData converts between v2 and v1 plistutil.
godrei
commented
Nov 10, 2025
| } | ||
| } | ||
|
|
||
| const infoPlistContent = `<?xml version="1.0" encoding="UTF-8"?> |
Contributor
Author
There was a problem hiding this comment.
These constants were in a separate Go file in the v1 version, this way it was part of the plistutil package, even if they are only used for tests.
godrei
commented
Nov 10, 2025
| @@ -0,0 +1,220 @@ | |||
| package plistutil | |||
Contributor
Author
There was a problem hiding this comment.
There are two changes compared to the v1 version:
- NewPlistDataFromFile constructor removed, so that the package is more lean (has less dependencies) and this constructor was only used in xcarchive package.
- Empty slice declaration using a literal warnings are fixed.
ofalvai
approved these changes
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate plistutil package to go-xcode/v2.