Skip to content

Use more idiomatic python #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pbuncic merged 1 commit into from
Jan 21, 2026
Merged

Use more idiomatic python #77

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions bits_helpers/cmd.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,14 +92,8 @@ def __init__(self, docker_image, docker_run_args=(), extra_env={}, extra_volumes
def __enter__(self):
if self._docker_image:
# "sleep inf" pauses forever, until we kill it.
envOpts = []
volumes = []
for env in self._extra_env.items():
envOpts.append("-e")
envOpts.append(f"{env[0]}={env[1]}")
for v in self._extra_volumes:
volumes.append("-v")
volumes.append(v)
envOpts = [opt for k, v in self._extra_env.items() for opt in ("-e", f"{k}={v}")]
volumes = [opt for v in self._extra_volumes for opt in ("-v", v)]
cmd = ["docker", "run", "--detach"] + envOpts + volumes + ["--rm", "--entrypoint="]
cmd += self._docker_run_args
cmd += [self._docker_image, "sleep", "inf"]
Expand Down