Skip to content

Conversation

@stevensonmt
Copy link
Contributor

@stevensonmt stevensonmt commented Jan 11, 2025

@stevensonmt
Copy link
Contributor Author

I don't understand the errors from the CI run. If someone can point me in the right direction I will try to resolve it, but I think it might be pointing more to how the CI runs are configured?

@stevensonmt stevensonmt changed the title Fix #80 -- improve efficiency of delete_vertex Fix #80 -- improve efficiency of delete_vertex and #85 improve efficiency of replace_vertex Jan 11, 2025
@stevensonmt
Copy link
Contributor Author

included #85 in this PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please double check that I've not mixed up incident and emanating edges here.

@stevensonmt
Copy link
Contributor Author

sorry, don't know why that stupid lexical log keeps showing up even after adding it to gitignore and deleting the directory (vim creates it again when it tries to use lexical for LSP).

@stevensonmt stevensonmt mentioned this pull request Jan 14, 2025
@bartblast
Copy link

Hey @bitwalker!

Just checking in about this PR - the performance fixes here would be really helpful for Hologram when handling large graphs. Any chance you'll be able to take a look at it soon?

@zblanco
Copy link
Contributor

zblanco commented Sep 24, 2025

I ran into this CI issue with my PR a while back and had to some different minor versions as old ones had their repos taken down. stevensonmt#1 adjusts the github workflow to explicitly reference some OTP / elixir versions that I could find pullable repos for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Poor performance of Graph.delete_vertex/2 in large graphs

3 participants