Fix erase for non-user partitions #1639
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The da_erase function was incomplete - it only handled "user" partition types but lacked the else clause for other partition types (like boot1, boot2, rpmb, etc.) that other similar DA commands have. This broke erasing special partitions such as preloader, which is needed to force devices into BROM mode (e.g. Motorola Moto G06 or G05/G15). Fixed by adding the missing else branch following the same pattern used in da_wl() and da_es().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The da_erase function was incomplete - it only handled "user" partition types but lacked the else clause for other partition types (like boot1, boot2, rpmb, etc.) that other similar DA commands have.
This broke erasing special partitions such as preloader, which is needed to force devices into BROM mode (e.g. Motorola Moto G06 or G05/G15).
Fixed by adding the missing else branch following the same pattern used in da_wl() and da_es().