-
Notifications
You must be signed in to change notification settings - Fork 23
Adding Install Script (Builds SDK from source, wf-pacman is installed from releases) #294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
AntonioND
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Python isn't actually required by BlocksDS. Only ArchitectDS and Nitro Engine use python, but those aren't mandatory.
In the original issue #214 I mentioned bash and PowerShell because those are two tools that Linux and Windows users are almost guaranteed to have in their systems. Python is in 99.99% of Linux systems, so it's fair to use it there, but I wouldn't expect Windows users to have it.
We could prebuild binaries for windows if you want to. In regards to the other windows specific issues, I had made a note at the top about some of that. I will make some of windows specific changes and will switch to using |
|
The installer has been updated here is an overview of what I did and why:
Notes: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My point is... You're still just running shell commands without checking for errors or anything, so this is worse than a simple bash script with set -e at the top that runs a bunch of commands and stops whenever one of them fails.
You need to ask users to install Python before running the setup script, which kinda defeats the purpose of the script. You need to point users to the Python docs, which is harder than copy-pasting a few commands from the WF setup page.
And this doesn't work on Windows anyway, so the only advantage of using Python isn't really there.
I'm really not convinced by this approach to the setup scripts. If more people support it I could change my mind, but this really doesn't simplify the setup instructions.
EDIT: On Windows you still need to follow different instructions to setup MinGW before you even run this script, not Python.
Shell error checker has been added. Users don't need to install python if it is built into an executable with something like PyInstaller (not the most efficient, but it's an installer), allowing this to be universal. What really needs to happen is an NSIS (or similar) installer needs to be made for windows if you want to simplify the install process further. This is not a python specific issue, the same issue would persist with powershell, Edit: found a way around this, but it would still be best to have an actual installer. |
|
Update: The windows install process is now completely automated without being dependent msys, also added batch file to compile for windows. |
fe52197 to
c8c3b23
Compare
I have made a simple python script and a shell script which automates the BlocksDS install process. It builds the BlocksDS sdk from scratch and pulls a prebuilt copy of
wf-pacmanfrom the official source listed in the docs.Why use Python instead of only shell script?:
Notes:
I would recommend running the shell script as administrator with something like
sudo bash Install_Linux.shso you don't have to type your password several times durring the install.